Skip to content

Hot Restart progress events #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 19, 2019
Merged

Hot Restart progress events #221

merged 2 commits into from
Mar 19, 2019

Conversation

grouma
Copy link
Member

@grouma grouma commented Mar 19, 2019

Closes #220

@grouma grouma requested a review from jakemac53 March 19, 2019 19:34
jakemac53
jakemac53 approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than the one nit

webdev/lib/src/daemon/app_domain.dart Outdated
@@ -23,6 +23,7 @@ class AppDomain extends Domain {
WebdevVmClient _webdevVmClient;
DebugService _debugService;
bool _isShutdown = false;
var _restartId = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more generic than just for restarts I think, it should be unique across all progress events at least so maybe _progressEventId?

@grouma grouma merged commit 4ffdc4d into master Mar 19, 2019
@grouma grouma deleted the updated-logs branch March 19, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grouma @jakemac53