From a9e3c1ce2c0555778969b845524556b97a8cf9bb Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Fri, 19 Aug 2022 12:35:54 -0700 Subject: [PATCH 1/2] Pass working directory to Process.run --- dwds/test/fixtures/context.dart | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/dwds/test/fixtures/context.dart b/dwds/test/fixtures/context.dart index 6cb0e8797..0e451f272 100644 --- a/dwds/test/fixtures/context.dart +++ b/dwds/test/fixtures/context.dart @@ -435,16 +435,12 @@ class TestContext { throw StateError( 'Expected to be in /dwds directory, instead path was $currentDir.'); } - try { - Directory.current = '$currentDir/debug_extension'; - final process = await Process.run( - 'tool/build_extension.sh', - ['prod'], - ); - print(process.stdout); - } finally { - Directory.current = currentDir; - } + final process = await Process.run( + 'tool/build_extension.sh', + ['prod'], + workingDirectory: '$currentDir/debug_extension', + ); + print(process.stdout); } Future _fetchDartDebugExtensionTab( From 35b1e7ef403a55c03dfcc633d9bd79017e97375e Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Fri, 19 Aug 2022 13:24:41 -0700 Subject: [PATCH 2/2] Add in missing echo --- dwds/debug_extension/tool/build_extension.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dwds/debug_extension/tool/build_extension.sh b/dwds/debug_extension/tool/build_extension.sh index 8babb2cb5..e93a93f93 100755 --- a/dwds/debug_extension/tool/build_extension.sh +++ b/dwds/debug_extension/tool/build_extension.sh @@ -33,6 +33,6 @@ echo "Building DDC-compiled extension to dev_build/web directory." echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" dart run build_runner build web --delete-conflicting-outputs --output dev_build echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" - "Updating the manifest.json file in dev_build/web directory." +echo "Updating the manifest.json file in dev_build/web directory." echo "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~" dart tool/update_dev_manifest.dart