Adds the setIsolatePauseMode method to Chrome Proxy Service

dwds/CHANGELOG.md

@@ -1,8 +1,9 @@
 ## 14.0.3-dev
-- Make data types null safe
+- Make data types null safe.
 - Update `package:vm_service` to 8.3.0.
 - Convert JavaScript stack traces in uncaught exceptions to Dart stack traces.
 - Fix failure to set breakpoints on windows with a base change in index.html.
+- Add the setIsolatePauseMode method to Chrome Proxy Service.
 
 ## 14.0.2
 - Update the min SDK constraint to 2.17.0.

dwds/lib/src/services/chrome_proxy_service.dart

@@ -741,6 +741,14 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension(
     }
   }
 
+  @override
+  Future<Success> setIsolatePauseMode(String isolateId,
+      {String exceptionPauseMode, bool shouldPauseOnExit}) async {
+    // TODO(elliette): Is there a way to respect the shouldPauseOnExit parameter
+    // in Chrome?
+    return setExceptionPauseMode(isolateId, exceptionPauseMode);
+  }
+
   @override
   Future<Success> setExceptionPauseMode(String isolateId, String mode) async {
     await isInitialized;

dwds/test/chrome_proxy_service_test.dart

@@ -1121,7 +1121,7 @@ void main() {
         expect(stack.truncated, isFalse);
       });
 
-      test('break on exceptions', () async {
+      test('break on exceptions with legacy setExceptionPauseMode', () async {
         final oldPauseMode =
             (await service.getIsolate(isolateId)).exceptionPauseMode;
         await service.setExceptionPauseMode(isolateId, ExceptionPauseMode.kAll);
@@ -1139,6 +1139,24 @@ void main() {
         await service.resume(isolateId);
       });
 
+      test('break on exceptions with setIsolatePauseMode', () async {
+        final oldPauseMode =
+            (await service.getIsolate(isolateId)).exceptionPauseMode;
+        await service.setIsolatePauseMode(isolateId,
+            exceptionPauseMode: ExceptionPauseMode.kAll);
+        // Wait for pausing to actually propagate.
+        var event = await stream
+            .firstWhere((event) => event.kind == EventKind.kPauseException);
+        expect(event.exception, isNotNull);
+
+        var stack = await service.getStack(isolateId);
+        expect(stack, isNotNull);
+
+        await service.setIsolatePauseMode(isolateId,
+            exceptionPauseMode: oldPauseMode);
+        await service.resume(isolateId);
+      });
+
       test('returns non-empty stack when paused', () async {
         await service.pause(isolateId);
         // Wait for pausing to actually propagate.