Batch Debugger.ScriptParsed events sent from the debug extension #1628
Conversation
| @@ -61,7 +62,10 @@ Tab _mostRecentDartTab; | |||
| DebuggerTrigger _debuggerTrigger; | |||
|
|
|||
| class DebugSession { | |||
| final SocketClient socketClient; | |||
| // How often to send batched events. | |||
There was a problem hiding this comment.
Nit: private fields should be listed after public ones
dwds/test/devtools_test.dart
Outdated
| // TODO(grouma): switch back to `fixture.webdriver.title` when | ||
| // https://github.com/flutter/devtools/issues/2045 is fixed. | ||
| expect(await context.webDriver.pageSource, contains('Flutter')); | ||
| expect(await context.webDriver.title, contains('Dart DevTools')); |
There was a problem hiding this comment.
This changes seem unrelated to this PR / the tests are still disabled. I think these changes should be made in a separate PR as part of re-enabling the tests.
There was a problem hiding this comment.
Agreed, will revert. I am concerned about those tests being disabled for too long though - we might break launching devtools inadvertently... We can use the same waiting for the devtools to launch technique as used in the debug_extension_tests to make the tests not flaky.
| @@ -3,7 +3,9 @@ | |||
| - Update `package:vm_service` to 8.3.0. | |||
| - Convert JavaScript stack traces in uncaught exceptions to Dart stack traces. | |||
| - Fix failure to set breakpoints on windows with a base change in index.html. | |||
|
|
|||
There was a problem hiding this comment.
One more nit: Looks like the DWDS change is actually just moving batched_stream.dart into shared utilities. Let's update CHANGELOG to reflect that
Update change log to reflect moving `batched_stream.dart` into shared utilities.
Batch Debugger.ScriptParsed events sent from the debug extension to extension backend.
Debugger.ScriptParsedand send the batches every second to the server.Debugger.ScriptParsedeventsNote: We introduced sending
Debugger.ScriptParsedevents to fix the issue #1557, this PR is a follow up making the solution faster.Closes: #1599
Related: #1621
Related: #1613