Skip to content

[DRAFT] Fix test flakes #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

elliette
Copy link
Contributor

No description provided.

@elliette elliette changed the title Fix test flakes [DRAFT] Fix test flakes May 12, 2022
@annagrin
Copy link
Contributor

annagrin commented May 17, 2022

Btw I was running some tests on windows and saw those failures as well. The devtools_tests failures seem to be due to a race - we are waiting for couple of seconds after pressing Alt-D and before checking for existence of the devtools window, but it seems this is not always enough time. We might need a more reliable way of detecting when devtools window have started - one way could be by listening to dwds.events and waiting for DebuggerReady event .

await Future.delayed(const Duration(seconds: 2));

@elliette elliette closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants