From d0750d1cabfcc96604c4f713e2d41fe331fec6f1 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Mon, 15 Nov 2021 15:38:14 -0800 Subject: [PATCH 1/4] Override noSuchMethod in DWDS --- dwds/lib/src/services/chrome_proxy_service.dart | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/dwds/lib/src/services/chrome_proxy_service.dart b/dwds/lib/src/services/chrome_proxy_service.dart index 7f2231a40..f39527174 100644 --- a/dwds/lib/src/services/chrome_proxy_service.dart +++ b/dwds/lib/src/services/chrome_proxy_service.dart @@ -1037,6 +1037,13 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension( Future setBreakpointState( String isolateId, String breakpointId, bool enable) => throw UnimplementedError(); + + /// Prevent DWDS from blocking Dart SDK rolls if changes in + /// package:vm_service are unimplemented in DWDS. + @override + dynamic noSuchMethod(Invocation invocation) { + return super.noSuchMethod(invocation); + } } /// The `type`s of [ConsoleAPIEvent]s that are treated as `stderr` logs. From 9bce4e93d416b03162830b2c26d9df989fedd94e Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Mon, 15 Nov 2021 15:45:51 -0800 Subject: [PATCH 2/4] Format comment --- dwds/lib/src/services/chrome_proxy_service.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dwds/lib/src/services/chrome_proxy_service.dart b/dwds/lib/src/services/chrome_proxy_service.dart index 73379c6ad..221beac56 100644 --- a/dwds/lib/src/services/chrome_proxy_service.dart +++ b/dwds/lib/src/services/chrome_proxy_service.dart @@ -1050,8 +1050,8 @@ ${globalLoadStrategy.loadModuleSnippet}("dart_sdk").developer.invokeExtension( throw UnimplementedError(); } - /// Prevent DWDS from blocking Dart SDK rolls if changes in - /// package:vm_service are unimplemented in DWDS. + /// Prevent DWDS from blocking Dart SDK rolls if changes in package:vm_service + /// are unimplemented in DWDS. @override dynamic noSuchMethod(Invocation invocation) { return super.noSuchMethod(invocation); From 3158ea37c4e2f712cfb307ee72cc8ce67195bbc7 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Tue, 16 Nov 2021 10:12:54 -0800 Subject: [PATCH 3/4] Unpin vmservice --- dwds/pubspec.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dwds/pubspec.yaml b/dwds/pubspec.yaml index dc511b34f..2726a5b17 100644 --- a/dwds/pubspec.yaml +++ b/dwds/pubspec.yaml @@ -32,8 +32,7 @@ dependencies: stack_trace: ^1.10.0 sse: ^4.1.0 uuid: '>=2.0.0 <4.0.0' - # We pin the version because we implement the interface. - vm_service: 7.4.0 + vm_service: ^1.0.0 web_socket_channel: ^2.0.0 webkit_inspection_protocol: ^1.0.0 From 58fac2a0f69f151d881061405c0ae8ed3978f22a Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Tue, 16 Nov 2021 10:15:09 -0800 Subject: [PATCH 4/4] Change version --- dwds/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dwds/pubspec.yaml b/dwds/pubspec.yaml index 2726a5b17..0152403b5 100644 --- a/dwds/pubspec.yaml +++ b/dwds/pubspec.yaml @@ -32,7 +32,7 @@ dependencies: stack_trace: ^1.10.0 sse: ^4.1.0 uuid: '>=2.0.0 <4.0.0' - vm_service: ^1.0.0 + vm_service: ^7.4.0 web_socket_channel: ^2.0.0 webkit_inspection_protocol: ^1.0.0