Skip to content

Commit ac0b33f

Browse files
committed
other thing...
1 parent 208c11b commit ac0b33f

File tree

4 files changed

+6
-8
lines changed

4 files changed

+6
-8
lines changed

appveyor.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,14 @@ install:
88
- ps: wget https://storage.googleapis.com/dart-archive/channels/dev/release/latest/sdk/dartsdk-windows-x64-release.zip -OutFile dart-sdk.zip
99
- cmd: echo "Unzipping dart-sdk..."
1010
- cmd: 7z x dart-sdk.zip -o"C:\tools" -y > nul
11-
- set PATH=%PATH%;C:\tools\dart-sdk\bin
1211
- set PATH=%PATH%;%APPDATA%\Pub\Cache\bin
1312
- cd webdev
14-
- pub get && exit 0
13+
- C:\tools\dart-sdk\bin\pub.bat get && exit 0
1514

1615
build: off
1716

1817
test_script:
19-
- pub run test -j 1
18+
- C:\tools\dart-sdk\bin\pub.bat run test -j 1
2019

2120
cache:
2221
- C:\Users\appveyor\AppData\Roaming\Pub\Cache

webdev/lib/src/pubspec.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class PackageExceptionDetails {
3838
}
3939

4040
Future _runPubDeps() async {
41-
var result = Process.runSync('pub', ['deps'], runInShell: true);
41+
var result = Process.runSync(pubPath, ['deps']);
4242

4343
if (result.exitCode == 65 || result.exitCode == 66) {
4444
throw new PackageException._(

webdev/lib/src/util.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ final String _sdkDir = (() {
2222
return aboveExecutable;
2323
})();
2424

25-
final String dartPath = p.join(_sdkDir, 'bin', 'dart');
25+
final String dartPath =
26+
p.join(_sdkDir, 'bin', Platform.isWindows ? 'dart.exe' : 'dart');
2627
final String pubPath =
2728
p.join(_sdkDir, 'bin', Platform.isWindows ? 'pub.bat' : 'pub');

webdev/test/integration_test.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -208,9 +208,7 @@ dependencies:
208208
test('should succeed with valid configuration', () async {
209209
var exampleDirectory = p.absolute(p.join(p.current, '..', 'example'));
210210
var process = await TestProcess.start(pubPath, ['get'],
211-
workingDirectory: exampleDirectory,
212-
environment: _getPubEnvironment(),
213-
runInShell: true);
211+
workingDirectory: exampleDirectory, environment: _getPubEnvironment());
214212

215213
await process.shouldExit(0);
216214

0 commit comments

Comments
 (0)