Skip to content

Commit 8515176

Browse files
authored
Remove check on web_dev_compilers (#19)
Going for a more general model
1 parent 3e31039 commit 8515176

File tree

4 files changed

+6
-49
lines changed

4 files changed

+6
-49
lines changed

webdev/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 0.1.2
2+
3+
- Remove check for `build_web_compilers`. Allows general support for
4+
`build_runner` from tools.
5+
16
## 0.1.1
27

38
- Checks for a dependency on `build_web_compilers`.

webdev/lib/src/pubspec.dart

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,6 @@ class PackageExceptionDetails {
3333
'You must have a dependency on `build_runner` in `pubspec.yaml`. '
3434
'It can be in either `dependencies` or `dev_dependencies`.');
3535

36-
static const noBuildWebCompilersDep = const PackageExceptionDetails._(
37-
'A dependency on `build_web_compilers` was not found.',
38-
description:
39-
'You must have a dependency on `build_web_compilers` in `pubspec.yaml` '
40-
'or transitively via another dependency.');
41-
4236
@override
4337
String toString() => [error, description].join('\n');
4438
}
@@ -87,11 +81,6 @@ Future checkPubspecLock() async {
8781
}
8882
}
8983

90-
var buldWebCompilers = packages['build_web_compilers'];
91-
if (buldWebCompilers == null) {
92-
issues.add(PackageExceptionDetails.noBuildWebCompilersDep);
93-
}
94-
9584
if (issues.isNotEmpty) {
9685
throw new PackageException._(issues);
9786
}

webdev/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: webdev
2-
version: 0.1.1
2+
version: 0.1.2-dev
33
author: Dart Team <[email protected]>
44
homepage: https://github.com/dart-lang/webdev
55
description: >-

webdev/test/integration_test.dart

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -71,29 +71,6 @@ packages:
7171
}
7272
});
7373

74-
test('should fail with no `build_web_compilers` dependency', () async {
75-
await d.file('pubspec.lock', '''
76-
# Copy-pasted from a valid run
77-
packages:
78-
build_runner:
79-
dependency: "direct main"
80-
description:
81-
name: build_runner
82-
url: "https://pub.dartlang.org"
83-
source: hosted
84-
version: "0.8.0"
85-
''').create();
86-
87-
var process = await TestProcess.start('dart', [_webdevBin, 'build'],
88-
workingDirectory: d.sandbox);
89-
90-
await expectLater(
91-
process.stdout, emits('Could not run in the current directory.'));
92-
await expectLater(process.stdout,
93-
emits('A dependency on `build_web_compilers` was not found.'));
94-
await process.shouldExit(78);
95-
});
96-
9774
test('should fail gracefully if there is no .packages file', () async {
9875
await d.file('pubspec.lock', '''
9976
# Copy-pasted from a valid run
@@ -105,13 +82,6 @@ packages:
10582
url: "https://pub.dartlang.org"
10683
source: hosted
10784
version: "0.8.0"
108-
build_web_compilers:
109-
dependency: "direct main"
110-
description:
111-
name: build_web_compilers
112-
url: "https://pub.dartlang.org"
113-
source: hosted
114-
version: "0.3.4+2"
11585
''').create();
11686

11787
var process = await TestProcess.start('dart', [_webdevBin, 'build'],
@@ -135,13 +105,6 @@ packages:
135105
url: "https://pub.dartlang.org"
136106
source: hosted
137107
version: "0.8.0"
138-
build_web_compilers:
139-
dependency: "direct main"
140-
description:
141-
name: build_web_compilers
142-
url: "https://pub.dartlang.org"
143-
source: hosted
144-
version: "0.3.4+2"
145108
''').create();
146109

147110
await d.file('.packages', '').create();

0 commit comments

Comments
 (0)