Skip to content

Commit d853f69

Browse files
committed
write additional version info into the readme (#126)
1 parent d1428ba commit d853f69

File tree

7 files changed

+39
-36
lines changed

7 files changed

+39
-36
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
`Node`.
1010
- Deprecated `NodeGlue.append` in favor of `Node.appendChild`.
1111
- Deprecated `NodeGlue.clone` in favor of `Node.cloneNode`.
12+
- Updated to `@webref/css` `6.10.0`.
1213

1314
## 0.4.0
1415

README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,12 @@ void main() {
3333

3434
## Web IDL version
3535

36+
Based on:
37+
3638
<!-- START updated by tool/update_bindings.dart. Do not modify by hand -->
37-
Based on [`@webref/idl 3.39.1`](https://www.npmjs.com/package/@webref/idl/v/3.39.1).
39+
- @webref/idl [3.39.1](https://www.npmjs.com/package/@webref/idl/v/3.39.1)
40+
- @webref/css [6.10.0](https://www.npmjs.com/package/@webref/css/v/6.10.0)
3841
<!-- END updated by tool/update_bindings.dart. Do not modify by hand -->
3942

4043
For instructions on re-generating the DOM bindings, see
41-
(bindings_generator/README.md)[bindings_generator/README.md].
44+
[bindings_generator/README.md](bindings_generator/README.md).

bindings_generator/generate_bindings.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Future<List<String>> _generateCSSStyleDeclarations() async {
2020
if (properties != null) {
2121
for (var j = 0; j < properties.length; j++) {
2222
final property = properties[j] as CSSEntry;
23-
// There are thre cases for [styleDeclaration]:
23+
// There are three cases for [styleDeclaration]:
2424
// 1) Length == 1, a single word CSS property.
2525
// 2) Length == 2, a kebab case property + a camel case property.
2626
// 3) Length == 3, webkit CSS properties.

bindings_generator/package-lock.json

Lines changed: 9 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bindings_generator/package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,10 @@
99
"author": "Dart project authors",
1010
"license": "BSD 3",
1111
"dependencies": {
12-
"@webref/css": "^6.5.6",
13-
"@webref/idl": "^3.23.0",
12+
"@webref/css": "^6.10.0",
13+
"@webref/idl": "^3.23.0"
14+
},
15+
"devDependencies": {
1416
"web-specs": "^2.74.1",
1517
"webidl2": "^24.2.2"
1618
}

lib/src/dom/cssom.dart

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,6 @@ extension CSSStyleDeclarationExtension on CSSStyleDeclaration {
221221
external String get alignItems;
222222
external set alignSelf(String value);
223223
external String get alignSelf;
224-
external set alignTracks(String value);
225-
external String get alignTracks;
226224
external set alignmentBaseline(String value);
227225
external String get alignmentBaseline;
228226
external set all(String value);
@@ -295,6 +293,8 @@ extension CSSStyleDeclarationExtension on CSSStyleDeclaration {
295293
external String get backgroundRepeat;
296294
external set backgroundSize(String value);
297295
external String get backgroundSize;
296+
external set backgroundTbd(String value);
297+
external String get backgroundTbd;
298298
external set baselineShift(String value);
299299
external String get baselineShift;
300300
external set baselineSource(String value);
@@ -603,6 +603,8 @@ extension CSSStyleDeclarationExtension on CSSStyleDeclaration {
603603
external String get dominantBaseline;
604604
external set emptyCells(String value);
605605
external String get emptyCells;
606+
external set fieldSizing(String value);
607+
external String get fieldSizing;
606608
external set fill(String value);
607609
external String get fill;
608610
external set fillBreak(String value);
@@ -789,6 +791,8 @@ extension CSSStyleDeclarationExtension on CSSStyleDeclaration {
789791
external String get inputSecurity;
790792
external set inset(String value);
791793
external String get inset;
794+
external set insetArea(String value);
795+
external String get insetArea;
792796
external set insetBlock(String value);
793797
external String get insetBlock;
794798
external set insetBlockEnd(String value);
@@ -809,8 +813,6 @@ extension CSSStyleDeclarationExtension on CSSStyleDeclaration {
809813
external String get justifyItems;
810814
external set justifySelf(String value);
811815
external String get justifySelf;
812-
external set justifyTracks(String value);
813-
external String get justifyTracks;
814816
external set layoutOrder(String value);
815817
external String get layoutOrder;
816818
external set left(String value);

tool/update_bindings.dart

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -98,26 +98,18 @@ $_usage''');
9898

9999
final sourceContent = readmeFile.readAsStringSync();
100100

101-
final replaceRegexp = RegExp(
102-
'''
103-
${RegExp.escape(_startComment)}
104-
.*
105-
${RegExp.escape(_endComment)}
106-
''',
107-
multiLine: true,
108-
);
109-
110-
final idlVersion = _webRefIdlVersion();
111-
112-
final idlReference = 'Based on [`$_webRefIdl $idlVersion`]'
113-
'(https://www.npmjs.com/package/$_webRefIdl/v/$idlVersion).';
114-
115-
final newContent = sourceContent.replaceFirst(replaceRegexp, '''
101+
final idlVersion = _packageLockVersion(_webRefIdl);
102+
final cssVersion = _packageLockVersion(_webRefCss);
103+
final versions = '''
116104
$_startComment
117-
$idlReference
118-
$_endComment
119-
''');
105+
- $_webRefIdl [$idlVersion](https://www.npmjs.com/package/$_webRefIdl/v/$idlVersion)
106+
- $_webRefCss [$cssVersion](https://www.npmjs.com/package/$_webRefCss/v/$cssVersion)
107+
''';
120108

109+
final newContent =
110+
sourceContent.substring(0, sourceContent.indexOf(_startComment)) +
111+
versions +
112+
sourceContent.substring(sourceContent.indexOf(_endComment));
121113
if (newContent == sourceContent) {
122114
print(ansi.styleBold.wrap('No update for readme.'));
123115
} else {
@@ -126,21 +118,21 @@ $_endComment
126118
}
127119
}
128120

129-
String _webRefIdlVersion() {
121+
String _packageLockVersion(String package) {
130122
final packageLockData = jsonDecode(
131123
File(p.join(_bindingsGeneratorPath, 'package-lock.json'))
132124
.readAsStringSync(),
133125
) as Map<String, dynamic>;
134126

135127
final packages = packageLockData['packages'] as Map<String, dynamic>;
136-
final webRefIdl =
137-
packages['node_modules/$_webRefIdl'] as Map<String, dynamic>;
128+
final webRefIdl = packages['node_modules/$package'] as Map<String, dynamic>;
138129
return webRefIdl['version'] as String;
139130
}
140131

141132
const _bindingsGeneratorPath = 'bindings_generator';
142133

143134
const _webRefIdl = '@webref/idl';
135+
const _webRefCss = '@webref/css';
144136

145137
const _thisScript = 'tool/update_bindings.dart';
146138

0 commit comments

Comments
 (0)