-
Notifications
You must be signed in to change notification settings - Fork 54
Watcher should use Directory.watch #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 Marked this as blocking dart-lang/pub#647. |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 dart-lang/sdk@500eb12 adds support for [Directory.watch] on Linux, and dart-lang/sdk@03337e9 adds it on Mac OS. Now only Windows remains. |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 Added Accepted label. |
<img src="https://avatars.githubusercontent.com/u/4865287?v=3" align="left" width="48" height="48"hspace="10"> Comment by lrhn Removed Area-Library label. |
<img src="https://avatars.githubusercontent.com/u/3276024?v=3" align="left" width="48" height="48"hspace="10"> Comment by anders-sandholm Removed Library-Watcher label. |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent Lowering the priority. The polling watcher doesn't use as much memory now. It would still be good to use the native watcher support, but it's not a burning issue. Removed Type-Defect, Priority-High labels. |
<img src="https://avatars.githubusercontent.com/u/2156198?v=3" align="left" width="48" height="48"hspace="10"> Comment by kasperl Removed this from the M8 milestone. |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent Marked this as being blocked by dart-lang/pub#1002. |
<img src="https://avatars.githubusercontent.com/u/22043?v=3" align="left" width="48" height="48"hspace="10"> Comment by skabet Landed native watching for Windows in dart-lang/sdk@146f951 + followups. While there may still may be tweaks to be made, it passes all current tests. Added Fixed label. |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="96" height="96"hspace="10"> Issue by nex3
Originally opened as dart-lang/sdk#14428
The polling watcher is very inefficient and memory-hungry, and is likely contributing towards issue dart-lang/pub#647. Now that dart:io exposes native watchers, we should use them where possible.
The text was updated successfully, but these errors were encountered: