Skip to content

Commit f1a5e7a

Browse files
authored
[package:markdown] update package:web references in the example (#2039)
1 parent a4ae175 commit f1a5e7a

File tree

4 files changed

+15
-11
lines changed

4 files changed

+15
-11
lines changed

.github/workflows/markdown.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ jobs:
7070
matrix:
7171
# Add macos-latest and/or windows-latest if relevant for this package.
7272
os: [ubuntu-latest]
73-
sdk: [3.2, dev]
73+
sdk: [3.4, dev]
7474
steps:
7575
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
7676
- uses: dart-lang/setup-dart@e51d8e571e22473a2ddebf0ef8a2123f0ab2c02c

pkgs/markdown/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
* Update the README link to the markdown playground
44
(https://dart-lang.github.io/tools).
5+
* Update `package:web` API references in the example.
6+
* Require Dart `^3.4.0`.
57

68
## 7.3.0
79

pkgs/markdown/example/app.dart

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ final extensionSets = {
4040
};
4141

4242
void main() {
43-
versionSpan.text = 'v${md.version}';
43+
versionSpan.textContent = 'v${md.version}';
4444
markdownInput.onKeyUp.listen(_renderMarkdown);
4545

46-
final savedMarkdown = window.localStorage['markdown'];
46+
final savedMarkdown = window.localStorage.getItem('markdown');
4747

4848
if (savedMarkdown != null &&
4949
savedMarkdown.isNotEmpty &&
@@ -57,7 +57,7 @@ void main() {
5757

5858
// GitHub is the default extension set.
5959
gfmRadio.attributes.getNamedItem('checked')?.value = '';
60-
gfmRadio.querySelector('.glyph')!.text = 'radio_button_checked';
60+
gfmRadio.querySelector('.glyph')!.textContent = 'radio_button_checked';
6161
extensionSet = extensionSets[gfmRadio.id];
6262
_renderMarkdown();
6363

@@ -82,7 +82,7 @@ void _renderMarkdown([Event? event]) {
8282

8383
if (event != null) {
8484
// Not simulated typing. Store it.
85-
window.localStorage['markdown'] = markdown;
85+
window.localStorage.setItem('markdown', markdown);
8686
}
8787
}
8888

@@ -110,19 +110,21 @@ void _switchFlavor(Event e) {
110110
if (target.attributes.getNamedItem('checked') == null) {
111111
if (basicRadio != target) {
112112
basicRadio.attributes.safeRemove('checked');
113-
basicRadio.querySelector('.glyph')!.text = 'radio_button_unchecked';
113+
basicRadio.querySelector('.glyph')!.textContent =
114+
'radio_button_unchecked';
114115
}
115116
if (commonmarkRadio != target) {
116117
commonmarkRadio.attributes.safeRemove('checked');
117-
commonmarkRadio.querySelector('.glyph')!.text = 'radio_button_unchecked';
118+
commonmarkRadio.querySelector('.glyph')!.textContent =
119+
'radio_button_unchecked';
118120
}
119121
if (gfmRadio != target) {
120122
gfmRadio.attributes.safeRemove('checked');
121-
gfmRadio.querySelector('.glyph')!.text = 'radio_button_unchecked';
123+
gfmRadio.querySelector('.glyph')!.textContent = 'radio_button_unchecked';
122124
}
123125

124126
target.attributes.getNamedItem('checked')?.value = '';
125-
target.querySelector('.glyph')!.text = 'radio_button_checked';
127+
target.querySelector('.glyph')!.textContent = 'radio_button_checked';
126128
extensionSet = extensionSets[target.id];
127129
_renderMarkdown();
128130
}

pkgs/markdown/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ executables:
1212
markdown:
1313

1414
environment:
15-
sdk: ^3.2.0
15+
sdk: ^3.4.0
1616

1717
dependencies:
1818
args: ^2.0.0
@@ -31,5 +31,5 @@ dev_dependencies:
3131
pool: ^1.5.1
3232
tar: ^1.0.3
3333
test: ^1.16.0
34-
web: '>=0.4.2 <2.0.0'
34+
web: ^1.0.0
3535
yaml: ^3.0.0

0 commit comments

Comments
 (0)