Skip to content

Commit 58383da

Browse files
committed
Use finally block
If there is no exception and we never close the servers they can hold the process open. I'm not sure if this fully explains the flakiness on travis...
1 parent f355958 commit 58383da

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

pkgs/test/lib/src/runner/node/platform.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,8 @@ class NodePlatform extends PlatformPlugin
124124
}));
125125

126126
return Pair(channel, pair.last);
127-
} catch (_) {
127+
} finally {
128128
unawaited(Future.wait(servers.map((s) => s.close().catchError((_) {}))));
129-
rethrow;
130129
}
131130
}
132131

0 commit comments

Comments
 (0)