Skip to content

Need tests for gen_snapshot #7020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dgrove opened this issue Nov 29, 2012 · 6 comments
Closed

Need tests for gen_snapshot #7020

dgrove opened this issue Nov 29, 2012 · 6 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@dgrove
Copy link
Contributor

dgrove commented Nov 29, 2012

In https://codereview.chromium.org/11416255, [email protected] asked about testing of gen_snapshot. I don't see any tests for this in the repo, so I can't modify an existing tests to test gen_snapshot in the SDK.

@dgrove
Copy link
Contributor Author

dgrove commented Nov 29, 2012

Marked this as blocking #6007.

@peter-ahe-google
Copy link
Contributor

cc @iposva-google.
cc @ricowind.

@a-siva
Copy link
Contributor

a-siva commented Jan 28, 2013

https://code.google.com/p/dart/source/detail?r=17680

dart has a new option --generate-script-snapshot which enables creation of a script snapshot from the standalone dart binary. With this change it is not necessary to add gen_snapshot to the SDK.

Marking bug as wontfix (we will not add gen_snapshot to the sdk).


Added WontFix label.

@peter-ahe-google
Copy link
Contributor

We still need to test the snapshot facility.

I suggest that we run all the VM tests from a (freshly created) snapshot.


Added Triaged label.

@iposva-google
Copy link
Contributor

UNIT_TEST_CASE(ScriptSnapshot) has been testing the script snapshot facility embedded in the dart binary for months.


cc @a-siva.
Added Fixed label.

@peter-ahe-google
Copy link
Contributor

I'm not sure I'm getting my point across.

As far as I can tell, snapshots are tested as follows:

* The platform libraries are loaded from a snapshot (and that snapshot is thoroughly tested).

* dart2js is loaded from a snapshot (and that snapshot is thoroughly tested).

* runtime/vm/snapshot_test.cc

I think this list is incomplete, for example, there is no testing of negative tests.

My fear is that if you don't test this as yet another configuration in test.dart, your users will run into problems as the VM evolves.

@dgrove dgrove added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Jan 28, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

4 participants