-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Need tests for gen_snapshot #7020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Marked this as blocking #6007. |
cc @iposva-google. |
https://code.google.com/p/dart/source/detail?r=17680 dart has a new option --generate-script-snapshot which enables creation of a script snapshot from the standalone dart binary. With this change it is not necessary to add gen_snapshot to the SDK. Marking bug as wontfix (we will not add gen_snapshot to the sdk). Added WontFix label. |
We still need to test the snapshot facility. I suggest that we run all the VM tests from a (freshly created) snapshot. Added Triaged label. |
I'm not sure I'm getting my point across. As far as I can tell, snapshots are tested as follows: * The platform libraries are loaded from a snapshot (and that snapshot is thoroughly tested). * dart2js is loaded from a snapshot (and that snapshot is thoroughly tested). * runtime/vm/snapshot_test.cc I think this list is incomplete, for example, there is no testing of negative tests. My fear is that if you don't test this as yet another configuration in test.dart, your users will run into problems as the VM evolves. |
In https://codereview.chromium.org/11416255, [email protected] asked about testing of gen_snapshot. I don't see any tests for this in the repo, so I can't modify an existing tests to test gen_snapshot in the SDK.
The text was updated successfully, but these errors were encountered: