Skip to content

implementation/compiler.dart contains inconsistent operator positioning #6999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
blois opened this issue Nov 28, 2012 · 1 comment
Closed

implementation/compiler.dart contains inconsistent operator positioning #6999

blois opened this issue Nov 28, 2012 · 1 comment
Assignees
@peter-ahe-google
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js

Comments

@blois
Copy link

blois commented Nov 28, 2012

Specifically maybeEnableJSHelper does not follow the style guide in positioning of operators for a multi-line expression.

http://www.dartlang.org/articles/style-guide/#do-place-the-operator-on-the-preceding-line-in-a-multi-line-expression

This came up during a review or https://codereview.chromium.org/11316113 where the code was being modified, but the request was that the formatting be handled as a separate issue.
@peter-ahe-google
Copy link
Contributor

We have bigger fish to fry.

Added WontFix label.

@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
@devx-ubiquity devx-ubiquity mentioned this issue May 27, 2025
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peter-ahe-google peter-ahe-google

Labels
closed-not-planned Closed as we don't intend to take action on the reported issue web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @blois @peter-ahe-google