Skip to content

CorrectionProducers computing should handle errors differently #60694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FMorschel opened this issue May 8, 2025 · 1 comment
Open

CorrectionProducers computing should handle errors differently #60694

FMorschel opened this issue May 8, 2025 · 1 comment
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-server Issues related to some aspect of the analysis server P3 A lower priority bug or feature request

Comments

@FMorschel
Copy link
Contributor

@bwilkerson's #60683 (comment)

[W]e should guard the execution of CorrectionProducers such that any exception thrown causes the correction to not be produced, but doesn't prevent other correction producers from running and results from being returned.

Opening this issue to track that work. I do have a question on how to handle this if we want to still get stacktraces for wrong cases?

@bwilkerson
Copy link
Member

The AnalysisServer has an InstrumentationService that supports a logExceptionResult method. The exception should be logged using that method when it's caught.

@lrhn lrhn added the area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. label May 8, 2025
@srawlins srawlins added P3 A lower priority bug or feature request devexp-server Issues related to some aspect of the analysis server labels May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-devexp For issues related to the analysis server, IDE support, linter, `dart fix`, and diagnostic messages. devexp-server Issues related to some aspect of the analysis server P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

4 participants