ensure all lints are relevant in Dart 2

[pq]

In cases where rules can be updated and remain valuable we should do so. If lints are no longer relevant we should deprecate and remove (e.g., #57809).

• deprecate prefer_bool_in_asserts deprecate / remove prefer_bool_in_asserts #57829
• deprecate super_goes_last

[pq]

In #57875, @kwalrath writes:

[W]e should certainly remove lints that are irrelevant or problematic in Dart 2. Some used to be in the style guide but were removed (see dart-lang/site-www#863, dart-lang/site-www#889, and other changes to Effective Dart). Here are some possibilities:

• always_declare_return_types
• avoid_types_on_closure_parameters
• type_annotate_public_apis
• super_goes_last: Irrelevant because Dart 2 enforces this. (I can't find this in the SDK changelog, but it's mentioned in More revisions to "Effective Dart" based on feedback. site-www#863.)
• prefer_constructors_over_static_methods: Irrelevant from the POV of reading code (though not from the implementer's or doc reader's POV).

[bwilkerson]

Other than 'super_goes_last' (assuming that code that violates the lint is no longer valid) I don't understand why there are problematic in Dart 2. Could someone add more details?

[pq]

This will be ongoing. Let's open new issues as new concerns arise.