Skip to content

pkg/vm/test/transformations/type_flow/summary_collector_test fails with records and patterns enabled #51692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
munificent opened this issue Mar 9, 2023 · 1 comment
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@munificent
Copy link
Member

I'm working to enable the experiment flags for "records" and "patterns" and this test is failing. I don't want to just update the expectations to get it to pass because I don't know what this test actually does. But it also doesn't look like a critical failure. So I'm just going to approve this failure for now and leave this bug to track it.

@munificent munificent added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Mar 9, 2023
@alexmarkov alexmarkov self-assigned this Mar 9, 2023
@alexmarkov
Copy link
Contributor

This is a unit test for building data flow representation (summary) which is used by global type flow analysis (TFA), a part of native AOT compiler and dart2wasm.

The expectations changed because CFE started generating sequences of if statements with extra operator== calls for old-style switch statements. Addressing #51391 should restore kernel AST for old-style switch statements which should fix the unit test.

I think it is fine to update the test expectations for now, as this is already tracked in #51391.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

2 participants