Skip to content

[CP] Cherrypick CFE FutureOr nullability fixes to Dart 2.17 #48763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Markzipan opened this issue Apr 7, 2022 · 3 comments
Closed

[CP] Cherrypick CFE FutureOr nullability fixes to Dart 2.17 #48763

Markzipan opened this issue Apr 7, 2022 · 3 comments
Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve legacy-area-front-end Legacy: Use area-dart-model instead. merge-to-beta

Comments

@Markzipan
Copy link
Contributor

commit(s) to merge: 7d8d3bb

merge instructions: clean merge

What is the issue: Undetermined nullability for FutureOr types was leaking through the CFE into our backends (detected first in DDC), as reported by Flutter users.

What is the fix: CFE-side fixes in type substitution.

Why cherrypick: This is causing problems right now for some Flutter web users (e.g., consumers of https://pub.dev/packages/riverpod).

Risk: Little

Link to original issue(s): #48631

/cc @mit-mit @whesse @athomas @vsmenon @devoncarew @sigmundch @nshahan

@Markzipan Markzipan added legacy-area-front-end Legacy: Use area-dart-model instead. cherry-pick-review Issue that need cherry pick triage to approve labels Apr 7, 2022
@sigmundch
Copy link
Member

I'm in favor of including this as part of 2.17 - the change is fairly small (most of the CL are tests, only 10 LOC of actual change), and it addresses an issue that is being hit by flutter web users.

@johnniwinther @leafpetersen - what do you think?

@johnniwinther
Copy link
Member

LGTM

@itsjustkevin itsjustkevin added the cherry-pick-approved Label for approved cherrypick request label Apr 20, 2022
@athomas
Copy link
Member

athomas commented Apr 25, 2022

Merged to beta in e5fa9de (2.17.0-266.7.beta).

@athomas athomas closed this as completed Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve legacy-area-front-end Legacy: Use area-dart-model instead. merge-to-beta
Projects
None yet
Development

No branches or pull requests

5 participants