Skip to content

Reported TSAN race on Field::CloneFromOriginal #47188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mkustermann opened this issue Sep 10, 2021 · 0 comments
Closed

Reported TSAN race on Field::CloneFromOriginal #47188

mkustermann opened this issue Sep 10, 2021 · 0 comments
Assignees
@aam
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-isolate

Comments

@mkustermann
Copy link
Member

From this log:

Running "out/ReleaseTSANX64/dart --disable-dart-dev -Drepeat=4 -Dshard=100 -Dshards=200 --no-sound-null-safety --enable-isolate-groups runtime/tests/concurrency/generated_stress_test.dart.jit.dill"
[/b/s/w/ir/cache/builder/sdk/runtime/tests/concurrency/../vm/dart_2/trigger_gc_in_native_test.dart] starting ...
...
==================
WARNING: ThreadSanitizer: data race (pid=18236)
  Atomic read of size 8 at 0x7fe873fe5698 by thread T17:
    #0 __tsan_atomic64_load ../staging/llvm_build/tools/clang/stage2-bins/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/compiler-rt/lib/tsan/rtl/tsan_interface_atomic.cpp:550 (dart+0x1e122fe)
    #1 unsigned long std::__2::__cxx_atomic_load<unsigned long>(std::__2::__cxx_atomic_base_impl<unsigned long> const*, std::__2::memory_order) ../../out/ReleaseTSANX64/../../buildtools/linux-x64/clang/bin/../include/c++/v1/atomic:1006 (dart+0x2169999)
    #2 <null> ../../out/ReleaseTSANX64/../../buildtools/linux-x64/clang/bin/../include/c++/v1/atomic:1615 (dart+0x2169999)
    #3 dart::Object::Clone(dart::Object const&, dart::Heap::Space, bool) ../../out/ReleaseTSANX64/../../runtime/vm/object.cc:2758 (dart+0x2169999)
    #4 dart::Field::CloneFromOriginal() const ../../out/ReleaseTSANX64/../../runtime/vm/object.cc:10821 (dart+0x219dcbc)
    #5 dart::Field::CloneFromOriginal() const ../../out/ReleaseTSANX64/../../runtime/vm/object.cc:10462 (dart+0x219dcbc)
    #6 dart::CallSpecializer::TryInlineImplicitInstanceGetter(dart::InstanceCallInstr*) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/call_specializer.cc:737 (dart+0x28f9092)
    #7 dart::CallSpecializer::TryInlineInstanceGetter(dart::InstanceCallInstr*) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/call_specializer.cc:968 (dart+0x28fb2fb)
    #8 dart::JitCallSpecializer::VisitInstanceCall(dart::InstanceCallInstr*) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/jit_call_specializer.cc:106 (dart+0x29a9eee)
    #9 dart::InstanceCallInstr::Accept(dart::FlowGraphVisitor*) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/backend/il.cc:1253 (dart+0x2808d3c)
    #10 dart::FlowGraphVisitor::VisitBlocks() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/backend/il.cc:1366 (dart+0x280b283)
    #11 dart::CallSpecializer::ApplyICData() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/call_specializer.cc:59 (dart+0x28f1a02)
    #12 dart::CompilerPass_ApplyICData::DoBody(dart::CompilerPassState*) const ../../out/ReleaseTSANX64/../../runtime/vm/compiler/compiler_pass.cc:389 (dart+0x2908819)
    #13 dart::CompilerPass::Run(dart::CompilerPassState*) const ../../out/ReleaseTSANX64/../../runtime/vm/compiler/compiler_pass.cc:214 (dart+0x2907a9e)
    #14 dart::CompilerPass::RunInliningPipeline(dart::CompilerPass::PipelineMode, dart::CompilerPassState*) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/compiler_pass.cc:265 (dart+0x2907f3e)
    #15 dart::CallSiteInliner::TryInliningImpl(dart::Function const&, dart::Array const&, dart::InlinedCallData*, bool) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/backend/inliner.cc:1211 (dart+0x2872269)
    #16 dart::CallSiteInliner::TryInlining(dart::Function const&, dart::Array const&, dart::InlinedCallData*, bool) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/backend/inliner.cc:900 (dart+0x2860892)
    #17 dart::PolymorphicInliner::TryInliningPoly(dart::TargetInfo const&) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/backend/inliner.cc:1816 (dart+0x285fc61)
    #18 dart::PolymorphicInliner::Inline() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/backend/inliner.cc:2217 (dart+0x2866efe)
    #19 dart::CallSiteInliner::InlineInstanceCalls() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/backend/inliner.cc:1578 (dart+0x28767d4)
    #20 dart::CallSiteInliner::InlineCalls() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/backend/inliner.cc:852 (dart+0x28691ce)
    #21 dart::FlowGraphInliner::Inline() ../../out/ReleaseTSANX64/../../runtime/vm/compiler/backend/inliner.cc:2397 (dart+0x2868bc5)
    #22 dart::CompilerPass_Inlining::DoBody(dart::CompilerPassState*) const ../../out/ReleaseTSANX64/../../runtime/vm/compiler/compiler_pass.cc:396 (dart+0x29089c5)
    #23 dart::CompilerPass::Run(dart::CompilerPassState*) const ../../out/ReleaseTSANX64/../../runtime/vm/compiler/compiler_pass.cc:214 (dart+0x2907a9e)
    #24 dart::CompilerPass::RunPipeline(dart::CompilerPass::PipelineMode, dart::CompilerPassState*) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/compiler_pass.cc:319 (dart+0x290829b)
    #25 dart::CompileParsedFunctionHelper::Compile(dart::CompilationPipeline*) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/compiler.cc:576 (dart+0x23555a8)
    #26 dart::CompileFunctionHelper(dart::CompilationPipeline*, dart::Function const&, bool, long) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/compiler.cc:721 (dart+0x23564bf)
    #27 dart::Compiler::CompileOptimizedFunction(dart::Thread*, dart::Function const&, long) ../../out/ReleaseTSANX64/../../runtime/vm/compiler/jit/compiler.cc:904 (dart+0x2356e9f)
    #28 dart::DRT_HelperOptimizeInvokedFunction(dart::Isolate*, dart::Thread*, dart::Zone*, dart::NativeArguments) ../../out/ReleaseTSANX64/../../runtime/vm/runtime_entry.cc:2976 (dart+0x22e3ce3)
    #29 dart::DRT_OptimizeInvokedFunction(dart::NativeArguments) ../../out/ReleaseTSANX64/../../runtime/vm/runtime_entry.cc:2945 (dart+0x22e3ce3)
    #30 <null> <null> (memfd:dart-codespace (deleted)+0x2542)
    #31 dart::DartEntry::InvokeFunction(dart::Function const&, dart::Array const&, dart::Array const&, unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/dart_entry.cc:147 (dart+0x208b21e)
    #32 dart::DartLibraryCalls::HandleMessage(long, dart::Instance const&) ../../out/ReleaseTSANX64/../../runtime/vm/dart_entry.cc:37 (dart+0x208f0f7)
    #33 dart::DartLibraryCalls::HandleMessage(long, dart::Instance const&) ../../out/ReleaseTSANX64/../../runtime/vm/dart_entry.cc:757 (dart+0x208f0f7)
    #34 dart::IsolateMessageHandler::HandleMessage(std::__2::unique_ptr<dart::Message, std::__2::default_delete<dart::Message> >) ../../out/ReleaseTSANX64/../../runtime/vm/isolate.cc:1398 (dart+0x20d57e5)
    #35 dart::MessageHandler::HandleMessages(dart::MonitorLocker*, bool, bool) ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:240 (dart+0x2120a1e)
    #36 dart::MessageHandler::TaskCallback() ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:450 (dart+0x21213cf)
    #37 dart::MessageHandlerTask::Run() ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:31 (dart+0x2121e53)
    #38 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:158 (dart+0x23328fa)
    #39 dart::ThreadPool::Worker::Main(unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:323 (dart+0x2333395)
    #40 dart::ThreadStart(void*) ../../out/ReleaseTSANX64/../../runtime/vm/os_thread_linux.cc:153 (dart+0x223c14d)

  Previous write of size 1 at 0x7fe873fe5698 by thread T11:
    #0 dart::Field::UpdateGuardedCidAndLength(dart::Object const&) const ../../out/ReleaseTSANX64/../../runtime/vm/object.h:723 (dart+0x21a25c1)
    #1 <null> ../../out/ReleaseTSANX64/../../runtime/vm/object.cc:10874 (dart+0x21a25c1)
    #2 <null> ../../out/ReleaseTSANX64/../../runtime/vm/object.h:4274 (dart+0x21a25c1)
    #3 dart::Field::UpdateGuardedCidAndLength(dart::Object const&) const ../../out/ReleaseTSANX64/../../runtime/vm/object.cc:11333 (dart+0x21a25c1)
    #4 dart::Field::RecordStore(dart::Object const&) const ../../out/ReleaseTSANX64/../../runtime/vm/object.cc:11703 (dart+0x21a42ce)
    #5 dart::DRT_HelperUpdateFieldCid(dart::Isolate*, dart::Thread*, dart::Zone*, dart::NativeArguments) ../../out/ReleaseTSANX64/../../runtime/vm/runtime_entry.cc:3465 (dart+0x22e5dbc)
    #6 dart::DRT_UpdateFieldCid(dart::NativeArguments) ../../out/ReleaseTSANX64/../../runtime/vm/runtime_entry.cc:3461 (dart+0x22e5dbc)
    #7 <null> <null> (memfd:dart-codespace (deleted)+0x2542)
    #8 dart::DartEntry::InvokeFunction(dart::Function const&, dart::Array const&, dart::Array const&, unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/dart_entry.cc:147 (dart+0x208b21e)
    #9 dart::DartLibraryCalls::HandleMessage(long, dart::Instance const&) ../../out/ReleaseTSANX64/../../runtime/vm/dart_entry.cc:37 (dart+0x208f0f7)
    #10 dart::DartLibraryCalls::HandleMessage(long, dart::Instance const&) ../../out/ReleaseTSANX64/../../runtime/vm/dart_entry.cc:757 (dart+0x208f0f7)
    #11 dart::IsolateMessageHandler::HandleMessage(std::__2::unique_ptr<dart::Message, std::__2::default_delete<dart::Message> >) ../../out/ReleaseTSANX64/../../runtime/vm/isolate.cc:1398 (dart+0x20d57e5)
    #12 dart::MessageHandler::HandleMessages(dart::MonitorLocker*, bool, bool) ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:240 (dart+0x2120a1e)
    #13 dart::MessageHandler::TaskCallback() ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:450 (dart+0x21213cf)
    #14 dart::MessageHandlerTask::Run() ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:31 (dart+0x2121e53)
    #15 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:158 (dart+0x23328fa)
    #16 dart::ThreadPool::Worker::Main(unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:323 (dart+0x2333395)
    #17 dart::ThreadStart(void*) ../../out/ReleaseTSANX64/../../runtime/vm/os_thread_linux.cc:153 (dart+0x223c14d)

  Location is global '<null>' at 0x000000000000 (memfd:dart-oldspace (deleted)+0x000000065698)

  Thread T17 'DartWorker' (tid=18255, running) created by thread T11 at:
    #0 pthread_create ../staging/llvm_build/tools/clang/stage2-bins/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:975 (dart+0x1dc6c5b)
    #1 dart::OSThread::Start(char const*, void (*)(unsigned long), unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/os_thread_linux.cc:172 (dart+0x223bfdc)
    #2 dart::ThreadPool::RunImpl(std::__2::unique_ptr<dart::ThreadPool::Task, std::__2::default_delete<dart::ThreadPool::Task> >) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:296 (dart+0x2331f8f)
    #3 dart::ThreadPool::RunImpl(std::__2::unique_ptr<dart::ThreadPool::Task, std::__2::default_delete<dart::ThreadPool::Task> >) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:94 (dart+0x2331f8f)
    #4 dart::MessageHandler::Run(dart::ThreadPool*, dart::MessageHandler::MessageStatus (*)(unsigned long), void (*)(unsigned long), unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.h:46 (dart+0x212061a)
    #5 dart::MessageHandler::Run(dart::ThreadPool*, dart::MessageHandler::MessageStatus (*)(unsigned long), void (*)(unsigned long), unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:121 (dart+0x212061a)
    #6 dart::Isolate::Run() ../../out/ReleaseTSANX64/../../runtime/vm/isolate.cc:2346 (dart+0x20d9f0c)
    #7 Dart_RunLoopAsync ../../out/ReleaseTSANX64/../../runtime/vm/dart_api_impl.cc:2061 (dart+0x29e0c7a)
    #8 dart::SpawnIsolateTask::Run(dart::Isolate*) ../../out/ReleaseTSANX64/../../runtime/lib/isolate.cc:730 (dart+0x20002c4)
    #9 dart::SpawnIsolateTask::RunLightweight(char const*) ../../out/ReleaseTSANX64/../../runtime/lib/isolate.cc:699 (dart+0x1fffd91)
    #10 dart::SpawnIsolateTask::Run() ../../out/ReleaseTSANX64/../../runtime/lib/isolate.cc:633 (dart+0x1fffab4)
    #11 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:158 (dart+0x23328fa)
    #12 dart::ThreadPool::Worker::Main(unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:323 (dart+0x2333395)
    #13 dart::ThreadStart(void*) ../../out/ReleaseTSANX64/../../runtime/vm/os_thread_linux.cc:153 (dart+0x223c14d)

  Thread T11 'DartWorker' (tid=18249, running) created by thread T9 at:
    #0 pthread_create ../staging/llvm_build/tools/clang/stage2-bins/runtimes/runtimes-x86_64-unknown-linux-gnu-bins/compiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp:975 (dart+0x1dc6c5b)
    #1 dart::OSThread::Start(char const*, void (*)(unsigned long), unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/os_thread_linux.cc:172 (dart+0x223bfdc)
    #2 dart::ThreadPool::RunImpl(std::__2::unique_ptr<dart::ThreadPool::Task, std::__2::default_delete<dart::ThreadPool::Task> >) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:296 (dart+0x2331f8f)
    #3 dart::ThreadPool::RunImpl(std::__2::unique_ptr<dart::ThreadPool::Task, std::__2::default_delete<dart::ThreadPool::Task> >) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:94 (dart+0x2331f8f)
    #4 dart::MessageHandler::Run(dart::ThreadPool*, dart::MessageHandler::MessageStatus (*)(unsigned long), void (*)(unsigned long), unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.h:46 (dart+0x212061a)
    #5 dart::MessageHandler::Run(dart::ThreadPool*, dart::MessageHandler::MessageStatus (*)(unsigned long), void (*)(unsigned long), unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/message_handler.cc:121 (dart+0x212061a)
    #6 dart::Isolate::Run() ../../out/ReleaseTSANX64/../../runtime/vm/isolate.cc:2346 (dart+0x20d9f0c)
    #7 Dart_RunLoopAsync ../../out/ReleaseTSANX64/../../runtime/vm/dart_api_impl.cc:2061 (dart+0x29e0c7a)
    #8 dart::SpawnIsolateTask::Run(dart::Isolate*) ../../out/ReleaseTSANX64/../../runtime/lib/isolate.cc:730 (dart+0x20002c4)
    #9 dart::SpawnIsolateTask::RunLightweight(char const*) ../../out/ReleaseTSANX64/../../runtime/lib/isolate.cc:699 (dart+0x1fffd91)
    #10 dart::SpawnIsolateTask::Run() ../../out/ReleaseTSANX64/../../runtime/lib/isolate.cc:633 (dart+0x1fffab4)
    #11 dart::ThreadPool::WorkerLoop(dart::ThreadPool::Worker*) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:158 (dart+0x23328fa)
    #12 dart::ThreadPool::Worker::Main(unsigned long) ../../out/ReleaseTSANX64/../../runtime/vm/thread_pool.cc:323 (dart+0x2333395)
    #13 dart::ThreadStart(void*) ../../out/ReleaseTSANX64/../../runtime/vm/os_thread_linux.cc:153 (dart+0x223c14d)

SUMMARY: ThreadSanitizer: data race ../../out/ReleaseTSANX64/../../buildtools/linux-x64/clang/bin/../include/c++/v1/atomic:1006 in unsigned long std::__2::__cxx_atomic_load<unsigned long>(std::__2::__cxx_atomic_base_impl<unsigned long> const*, std::__2::memory_order)
==================
[/b/s/w/ir/cache/builder/sdk/runtime/tests/concurrency/../../../tests/lib_2/typed_data/float32x4_transpose_test.dart] finished
[/b/s/w/ir/cache/builder/sdk/runtime/tests/concurrency/../../../tests/standalone_2/no_support_timeline_test.dart] starting ...
[/b/s/w/ir/cache/builde

@aam seems related to field cloning, could you take a look?
@mkustermann mkustermann added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-isolate labels Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aam aam

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-isolate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aam @mkustermann