Skip to content

triple-shift co19 tests failing on ia32 #45074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whesse opened this issue Feb 22, 2021 · 2 comments
Closed

triple-shift co19 tests failing on ia32 #45074

whesse opened this issue Feb 22, 2021 · 2 comments
Assignees

Comments

@whesse
Copy link
Contributor

whesse commented Feb 22, 2021

The triple-shift tests changed from compile-time error to runtime error on the ia32 architectures, saying "not implemented yet"

The tests
co19/LanguageFeatures/nnbd/triple-shift/local_variable_read_A01_t03 RuntimeError (expected Pass)
co19/LanguageFeatures/nnbd/triple-shift/local_variable_read_A02_t03 RuntimeError (expected Pass)
co19/LanguageFeatures/nnbd/triple-shift/null_aware_operator_A09_t12 RuntimeError (expected Pass)
co19/LanguageFeatures/nnbd/triple-shift/null_aware_operator_A11_t12 RuntimeError (expected Pass)
co19/LanguageFeatures/nnbd/triple-shift/null_aware_operator_A13_t12 RuntimeError (expected Pass)
co19/LanguageFeatures/nnbd/triple-shift/null_aware_operator_A15_t12 RuntimeError (expected Pass)
co19/LanguageFeatures/nnbd/weak/triple-shift/local_variable_read_A01_t03 RuntimeError (expected Pass)
co19/LanguageFeatures/nnbd/weak/triple-shift/local_variable_read_A02_t03 RuntimeError (expected Pass)
co19/LanguageFeatures/nnbd/weak/triple-shift/null_aware_operator_A09_t12 RuntimeError (expected Pass)
co19/LanguageFeatures/nnbd/weak/triple-shift/null_aware_operator_A11_t12 RuntimeError (expected Pass)
co19/LanguageFeatures/nnbd/weak/triple-shift/null_aware_operator_A13_t12 RuntimeError (expected Pass)
co19/LanguageFeatures/nnbd/weak/triple-shift/null_aware_operator_A15_t12 RuntimeError (expected Pass)
co19/Language/Expressions/Shift/integer_t04/01
co19/Language/Expressions/Shift/integer_t04/02
co19/Language/Expressions/Shift/integer_t04/03
co19/Language/Expressions/Shift/integer_t04/04
co19/Language/Expressions/Shift/integer_t04/05
co19/Language/Expressions/Shift/integer_t04/06
co19/Language/Expressions/Shift/integer_t04/07

on configurations
dartk-strong-linux-debug-ia32
dartk-weak-asserts-linux-debug-ia32

are failing with errors like

stderr:
Unhandled exception:
UnimplementedError: int.>>> is not implemented yet
#0 int.>>> (dart:core-patch/integers.dart:110:5)
#1 main (file:///b/s/w/ir/out/DebugIA32/generated_tests/co19/Language/Expressions/Shift/integer_t04_01.dart:19:17)
#2 _delayEntrypointInvocation. (dart:isolate-patch/isolate_patch.dart:283:19)
#3 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:184:12)

--- Re-run this test:
python tools/test.py -n dartk-strong-linux-debug-ia32 co19/Language/Expressions/Shift/integer_t04/01

@alexmarkov
Copy link
Contributor

That's an expected improvement in behavior after I added operator >>> to int class. That operator is not implemented yet, hence run-time error.

@alexmarkov
Copy link
Contributor

Duplicate to #30892.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants