Skip to content

Make "why not promoted" information more discoverable in IntelliJ #44901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stereotype441 opened this issue Feb 9, 2021 · 2 comments
Closed
Assignees
Labels
area-intellij Tracking issues for the Dart IntelliJ plugin.

Comments

@stereotype441
Copy link
Member

stereotype441 commented Feb 9, 2021

(Parent issue #44897)

As of a42244f, the analyzer now generates context messages in some circumstances explaining why type promotion failed. IntelliJ integration exposes these messages to the user via a right click on the error message. We would like these messages to show up in a way that's more easily discoverable.

Yesterday we discussed some possibilities for how to do this. In an ideal world we'd like the "problems" view to have a tree structure so that the user can see context messages as collapsible leaves underneath the error messages. Unfortunately there are performance limitations getting in the way of doing this when the error count is large. Possible ways around the performance issues include:

  • Switching to a table view when the error count is large
  • Automatically filtering to just the current file (or perhaps folder) when the error count is large
  • displaying the context messages as a new, third column in the problems view

In addition, we might want to display the context messages in the tooltips for the analysis errors.

@stereotype441
Copy link
Member Author

@jwren any progress on this?

@jwren
Copy link
Member

jwren commented Feb 22, 2021

Yes, the content is now shown, it was not in IJ, but now is:

pkfphcocockpbiao

Other opportunities still exist to make it better which can be tracked with other issues as needed.

@jwren jwren closed this as completed Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-intellij Tracking issues for the Dart IntelliJ plugin.
Projects
None yet
Development

No branches or pull requests

2 participants