Skip to content

sendandexit_test requires enable-isolate-groups, is not compatible with hotreload bots #41625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aam opened this issue Apr 22, 2020 · 2 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@aam
Copy link
Contributor

aam commented Apr 22, 2020

/===================================================================\
| vm/dart/sendandexit_test is new and failed (Crash, expected Pass) |
\===================================================================/

--- Command "vm" (took 03.000829s):
DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart --hot-reload-rollback-test-mode --enable-isolate-groups --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/runtime/tests/vm/dart/sendandexit_test.dart

exit code:
-6

stderr:
../../runtime/vm/isolate.cc: 1747: error: expected: !FLAG_enable_isolate_groups
version=2.9.0-edge.17654b70d720917cfd3c222dba85e21ac67a2353 (be) (Wed Apr 22 17:34:09 2020 +0000) on "linux_x64"
pid=23535, thread=23535, isolate=main(0x5619b4656900)
isolate_instructions=5619b2ede320, vm_instructions=5619b2ede320
  pc 0x00005619b31b07fc fp 0x00007ffe5e5b01f0 dart::Profiler::DumpStackTrace(void*)+0x7c
  pc 0x00005619b2ede452 fp 0x00007ffe5e5b02d0 dart::Assert::Fail(char const*, ...)+0x82
  pc 0x00005619b3100544 fp 0x00007ffe5e5b0380 out/ReleaseX64/dart+0x1a54544
  pc 0x00005619b32006db fp 0x00007ffe5e5b0570 dart::DRT_StackOverflow(dart::NativeArguments)+0x66b
  pc 0x00007f65808812b8 fp 0x00007ffe5e5b05b0 Unknown symbol
  pc 0x00007f657fca50f0 fp 0x00007ffe5e5b05d8 Unknown symbol
  pc 0x00007f658088174c fp 0x00007ffe5e5b0648 Unknown symbol
  pc 0x00005619b30c3e02 fp 0x00007ffe5e5b06e0 dart::DartEntry::InvokeCode(dart::Code const&, dart::Array const&, dart::Array const&, dart::Thread*)+0x112
  pc 0x00005619b30c3b69 fp 0x00007ffe5e5b0770 dart::DartEntry::InvokeFunction(dart::Function const&, dart::Array const&, dart::Array const&, unsigned long)+0x2e9
  pc 0x00005619b316ce39 fp 0x00007ffe5e5b07e0 dart::Library::Invoke(dart::String const&, dart::Array const&, dart::Array const&, bool, bool) const+0x279
  pc 0x00005619b3640f87 fp 0x00007ffe5e5b08c0 Dart_Invoke+0x5d7
  pc 0x00005619b2ec886a fp 0x00007ffe5e5b0950 dart::bin::RunMainIsolate(char const*, dart::bin::CommandLineOptions*)+0x39a
  pc 0x00005619b2ec9678 fp 0x00007ffe5e5b0a60 dart::bin::main(int, char**)+0x468
  pc 0x00005619b2eca0cd fp 0x00007ffe5e5b0a80 main+0xd
-- End of DumpStackTrace
[exit     : sp(0) fp(0x7ffe5e5b05b0) pc(0)]
[dart     : sp(0x7ffe5e5b05c0) fp(0x7ffe5e5b05d8) pc(0x7f657fca50f0) dart:isolate_::__startMainIsolate@1026248 ]
[entry    : sp(0x7ffe5e5b05e8) fp(0x7ffe5e5b0648) pc(0x7f658088174c)]

--- Re-run this test:
python tools/test.py -n dartk-reload-rollback-linux-release-x64 vm/dart/sendandexit_test
@aam aam added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Apr 22, 2020
@maks
Copy link

maks commented Jan 12, 2021

I'm seeing this with current master too, but I am guessing this is temporary while @mkustermann is doing the work on #36097 ?

But whats more troubling is that per what I filed in #44640 even without isolate-groups hot-reload appears to be broken for spawned isolates.

@mkustermann
Copy link
Member

Correct, JIT support is still in-progress and hot-reload and a few other things are not yet implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

3 participants