Skip to content

Constant evaluation error in vm/reflect_core_vm_test when switching the parser to fasta #33994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devoncarew opened this issue Jul 26, 2018 · 8 comments
Labels
analyzer-constants legacy-area-analyzer Use area-devexp instead. P4 type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@devoncarew
Copy link
Member

@danrubel

@bwilkerson
Copy link
Member

Are there failures to track here, or can we close this?

@devoncarew
Copy link
Member Author

I see only one reference in the sdk, in language_2/language_2_analyzer.status, for the vm/reflect_core_vm_test test.

@danrubel
Copy link

danrubel commented Aug 28, 2018

After the switch, these issues still need to be addressed:

  • vm/reflect_core_vm_test in language_2/language_2_analyzer.status

@bwilkerson bwilkerson added the type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) label Aug 28, 2018
@devoncarew devoncarew changed the title meta issue to track analyzer language2 test failures when switching the parser to fasta analyzer language2 test failures when switching the parser to fasta Sep 6, 2018
@devoncarew
Copy link
Member Author

@danrubel, I moved a few from the list above (which didn't seem necessarily language_2 related) to #34395.

@danrubel
Copy link

The reflect_core_vm_test.dart appears to parse and build an AST correctly. It generates a error stating Evaluation of this constant expression throws an expression.

@bwilkerson
Copy link
Member

Does the test need to be updated (either to not have that error or to expect an error)? Or is there a bug in the constant evaluation code?

@danrubel
Copy link

Good question. I'm hoping that someone with better knowledge of the const evaluation system will chime in.

@stereotype441 stereotype441 changed the title analyzer language2 test failures when switching the parser to fasta Constant evaluation error in vm/reflect_core_vm_test when switching the parser to fasta Oct 21, 2018
@srawlins srawlins added the P4 label Jan 11, 2021
@srawlins
Copy link
Member

Closing as stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-constants legacy-area-analyzer Use area-devexp instead. P4 type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

4 participants