Skip to content

Refactor analyzer-cli / ddc to share command-line / config logic #27511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsmenon opened this issue Oct 6, 2016 · 4 comments
Closed

Refactor analyzer-cli / ddc to share command-line / config logic #27511

vsmenon opened this issue Oct 6, 2016 · 4 comments
Assignees
Labels
legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@vsmenon
Copy link
Member

vsmenon commented Oct 6, 2016

Logic around resolvers, summaries, and other context setup should be shared as much as possible. Ideally, this file in DDC and related setup calls into shared (with analyzer-cli) code instead:

https://github.com/dart-lang/sdk/blob/master/pkg/dev_compiler/lib/src/analyzer/context.dart

This will ensure analyzer-cli and ddc take consistent options and reduce work when adding new ones.

@vsmenon vsmenon added the legacy-area-analyzer Use area-devexp instead. label Oct 6, 2016
@bwilkerson bwilkerson added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable P2 A bug or feature request we're likely to work on labels Oct 7, 2016
@vsmenon vsmenon added P1 A high priority bug; for example, a single project is unusable or has many test failures and removed P2 A bug or feature request we're likely to work on labels Oct 7, 2016
@jmesserly
Copy link

this was also filed as #27252

@bwilkerson bwilkerson added P2 A bug or feature request we're likely to work on and removed P1 A high priority bug; for example, a single project is unusable or has many test failures labels Nov 29, 2016
@danrubel
Copy link

Once https://codereview.chromium.org/2598593003/ lands, you'll be able to use all of the standard analysis options command line flags such as --options and --enable-strict-call-checks

@nex3
Copy link
Member

nex3 commented Jun 28, 2017

@danrubel Does that mean this has been fixed?

@danrubel
Copy link

Yes. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legacy-area-analyzer Use area-devexp instead. P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Development

No branches or pull requests

5 participants