Skip to content

--package-root argument should accept a URI #27265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vsmenon opened this issue Sep 6, 2016 · 4 comments
Closed

--package-root argument should accept a URI #27265

vsmenon opened this issue Sep 6, 2016 · 4 comments
Labels
closed-obsolete Closed as the reported issue is no longer relevant dev-compiler-ux web-dev-compiler

Comments

@vsmenon
Copy link
Member

vsmenon commented Sep 6, 2016

From @nex3 on July 28, 2016 0:18

It looks like the --package-root argument assumes that it's a filesystem path. To match other Dart tools, it should accept a URI instead.

This is blocking dart-lang/test#414

Copied from original issue: dart-archive/dev_compiler#611
@vsmenon vsmenon added web-dev-compiler P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Sep 6, 2016
@vsmenon vsmenon mentioned this issue Sep 6, 2016
Closed
@nex3 nex3 mentioned this issue Sep 30, 2016
Closed
@vsmenon vsmenon added dev-compiler-ux and removed P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Jan 6, 2017
@nex3
Copy link
Member

nex3 commented Jun 28, 2017

@danrubel Did https://codereview.chromium.org/2598593003/ fix this?

@danrubel
Copy link

Not sure.

@nex3
Copy link
Member

nex3 commented Jun 28, 2017

I tried it, and it looks like it's not yet fixed.

@jmesserly
Copy link

I believe package-root is gone in favor of the packages file

@jmesserly jmesserly added the closed-obsolete Closed as the reported issue is no longer relevant label Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-obsolete Closed as the reported issue is no longer relevant dev-compiler-ux web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nex3 @jmesserly @vsmenon @danrubel