Skip to content

Show unused variables in different color #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue Apr 5, 2012 · 11 comments
Closed

Show unused variables in different color #2463

DartBot opened this issue Apr 5, 2012 · 11 comments
Assignees
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug
Milestone

Comments

@DartBot
Copy link

DartBot commented Apr 5, 2012

This issue was originally filed by @ahmetaa


Show unused class and method parameters in different color, possibly gray.
Editor Build: 5845

@kasperl
Copy link

kasperl commented Apr 11, 2012

Added Area-Editor, Triaged labels.

@stevemessick
Copy link
Contributor

Set owner to @stevemessick.
Removed Type-Defect label.
Added Type-Enhancement label.

@danrubel
Copy link

danrubel commented Jun 1, 2012

Added this to the Later milestone.

@danrubel
Copy link

danrubel commented Jun 1, 2012

Issue #3117 has been merged into this issue.

@scheglov
Copy link
Contributor

scheglov commented Jun 1, 2012

Could be just warning, as for Java in Eclipse.

Unused variable is a sloppy code, not something what you want to miss.
So, no grey or other pale color.
And IMHO not color at all.

@munificent
Copy link
Member

What about cases like this:

    return entrypoint.installDependencies().transform((_) {
      print('Dependencies installed!');
    });

Here, I'm waiting for the future to complete, but it doesn't complete with an interesting value. There's nothing at all wrong with this code, so I wouldn't want to see a warning or color here.

@scheglov
Copy link
Contributor

scheglov commented Jun 1, 2012

Hm... Agree.
In Java I never enable warning for unused parameters.

I come here from http://code.google.com/p/dart/issues/detail?id=3117 which speaks about unused variables. This type of warning I'd like to have though.

Best solution could be having just preference page with warnings and specific types of decorations for them. But I'm afraid that my team members will want to kick me for saying this :-)

@clayberg
Copy link

Issue #7818 has been merged into this issue.

@clayberg
Copy link

Issue #9147 has been merged into this issue.

@stevemessick
Copy link
Contributor

Added NotPlanned label.

@clayberg
Copy link

Removed this from the Later milestone.
Added this to the M5 milestone.

@DartBot DartBot added Type-Enhancement closed-not-planned Closed as we don't intend to take action on the reported issue labels Jun 10, 2013
@DartBot DartBot added this to the M5 milestone Jun 10, 2013
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

8 participants