Skip to content

Task model has consistency and performance issues #24601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bwilkerson opened this issue Oct 15, 2015 · 6 comments
Closed

Task model has consistency and performance issues #24601

bwilkerson opened this issue Oct 15, 2015 · 6 comments
Assignees
@bwilkerson
Labels
devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
1.13

Comments

@bwilkerson
Copy link
Member

The test for this is here: https://github.com/dart-lang/sdk/blob/master/pkg/analyzer/test/src/task/dart_test.dart#L1915
@bwilkerson bwilkerson added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures legacy-area-analyzer Use area-devexp instead. devexp-server Issues related to some aspect of the analysis server labels Oct 15, 2015
@bwilkerson bwilkerson self-assigned this Oct 15, 2015
@bwilkerson bwilkerson added this to the 1.13 milestone Oct 15, 2015
@bwilkerson
Copy link
Member Author

These at least partially solve the problem:

https://codereview.chromium.org/1403003002/
https://codereview.chromium.org/1409813002/

Further testing needed.

@mit-mit
Copy link
Member

mit-mit commented Oct 20, 2015

Any news? Shall we get these cherry picked?

@bwilkerson
Copy link
Member Author

They have been cherry picked. Waiting for feedback to know whether they have solved the problem or whether there is more work to be done.

@scheglov scheglov mentioned this issue Oct 22, 2015
Closed
5 tasks
@mit-mit
Copy link
Member

mit-mit commented Oct 23, 2015

@scheglov, did we conclude if this is fixed?

@bwilkerson
Copy link
Member Author

No, we haven't really concluded anything. I believe that the specific problem that prompted this issue to be opened has been fixed, but this issue has sort of become a more general "task model is not ready to ship" marker issue. I'll update the title to reflect that.

@bwilkerson bwilkerson changed the title Analysis server get out of sync after edits Task model has consistency and performance issues Oct 23, 2015
@bwilkerson
Copy link
Member Author

I believe that this is now fixed. We are no longer seeing the problems we were having before.

@danrubel danrubel mentioned this issue Oct 28, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwilkerson bwilkerson

Labels
devexp-server Issues related to some aspect of the analysis server legacy-area-analyzer Use area-devexp instead. P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
1.13
Development

No branches or pull requests
2 participants
@bwilkerson @mit-mit