Skip to content

pub get/upgrade/install should not create packages directories in sub-projects #23296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue Apr 22, 2015 · 5 comments
Closed
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue

Comments

@DartBot
Copy link

DartBot commented Apr 22, 2015

This issue was originally filed by @zoechi


Normally pub upgrade (or get/install) creates packages only in a subset of the folders bin (only one or two levels deep AFAIR), test, example, web but for example not in lib, or build.
When I have a nested project for example in example, pub upgrade creates packages directory in every sub-directory of example, also for example in myprj/example/my_sub_prj/lib/src.

@nex3
Copy link
Member

nex3 commented Apr 22, 2015

Pub doesn't have a notion of "sub-projects", and there aren't plans to add one. We could theoretically say that it doesn't create "packages" directories below a directory with a pubspec, but without a strong sub-project convention that seems more confusing than helpful, especially if users have pubspecs that they want to treat as data.


Added NotPlanned label.

@DartBot
Copy link
Author

DartBot commented Apr 22, 2015

This comment was originally written by @zoechi


Seems a bit inconsistent. Related DartEditor and Analyzer bugs were fixed.
Are there any plans for improvements in this area (dependencies for bin/example/tool/test or sub-projects)?

@DartBot
Copy link
Author

DartBot commented Apr 22, 2015

This comment was originally written by @zoechi


Even when Pub does not have a notion of "sub-projects" doesn't mean it isn't useful and also doesn't mean it needs to be prevented. I think this is the simplest way to improve the life for developers.

@nex3
Copy link
Member

nex3 commented Apr 22, 2015

Are there any plans for improvements in this area (dependencies for
bin/example/tool/test or sub-projects)?

No.

Also, as I've stated many times before, "bin" should not be thought of as a separate project anyway, since it's part of a package's public API.

Even when Pub does not have a notion of "sub-projects" doesn't mean it isn't
useful and also doesn't mean it needs to be prevented. I think this is the
simplest way to improve the life for developers.

There's nothing preventing you from just running "pub get" again in your examples.

@DartBot DartBot added Type-Defect closed-not-planned Closed as we don't intend to take action on the reported issue labels Apr 22, 2015
@DartBot
Copy link
Author

DartBot commented Jun 4, 2015

This issue has been moved to dart-lang/pub#12.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue
Projects
None yet
Development

No branches or pull requests

3 participants