Skip to content

Crash on content shell on checked javascript_int_overflow_test #17525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whesse opened this issue Mar 17, 2014 · 6 comments
Closed

Crash on content shell on checked javascript_int_overflow_test #17525

whesse opened this issue Mar 17, 2014 · 6 comments
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@whesse
Copy link
Contributor

whesse commented Mar 17, 2014

Content shell crashes on MacOS in checked mode on javascript_int_overflow_test and javascript_int_overflow_literal_test.

This crash happens almost every run.

@whesse
Copy link
Contributor Author

whesse commented Mar 17, 2014

This seems to start before revision 33708. It looks like it is between 33701 and 33708, but it may be earlier. It is not just on MacOS, but on all platforms.


Removed OpSys-OSX label.
Changed the title to: "Crash on content shell on checked javascript_int_overflow_test".

@a-siva
Copy link
Contributor

a-siva commented Mar 17, 2014

This is a dup of 13719. I will update the standalone status file to reflect this.


Added Duplicate label.
Marked as being merged into #13719.

@whesse
Copy link
Contributor Author

whesse commented Mar 17, 2014

Is it really a dup of 13719? It is not a failure, but a crash, and it started suddenly because of some change. I don't see how the cause of these new failures is the same as the cause listed in 13719. The change in the status file at 13700 should not affect the status on content shell, so I don't think that is the cause.

@a-siva
Copy link
Contributor

a-siva commented Mar 17, 2014

You right the crash is related to change https://code.google.com/p/dart/source/detail?r=33704
This code fails with an overflow error when the flag --throw_on_javascript_int_overflow is passed in.

@a-siva
Copy link
Contributor

a-siva commented Mar 17, 2014

This is not a dup of 13719


Added Accepted label.
Marked as being merged into #.

@iposva-google
Copy link
Contributor

Fixed with r33778.


Added Fixed label.

@whesse whesse added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures labels Mar 17, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

3 participants