Skip to content

A number of html libraries are failing on the analyzer #16522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ricowind opened this issue Feb 4, 2014 · 13 comments
Open

A number of html libraries are failing on the analyzer #16522

ricowind opened this issue Feb 4, 2014 · 13 comments
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. library-html P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable web-libraries Issues impacting dart:html, etc., libraries
Milestone

Comments

@ricowind
Copy link
Contributor

ricowind commented Feb 4, 2014

There is a number of unassigned suppression for CompileTimeErrors on the analyzer in tests/analyzer/analyze_library.status for html libraries.

I will mark these with this bug number, please go through them and fix up the status files or make bugs against the analyzer if there are bugs there.

Marking the following with this bug:
lib/_chrome/dart2js/chrome_dart2js: CompileTimeError
lib/html/dartium/html_dartium: CompileTimeError
lib/html/html_common/html_common: CompileTimeError
lib/html/html_common/html_common_dart2js: CompileTimeError

@ricowind
Copy link
Contributor Author

ricowind commented Feb 4, 2014

Added this to the 1.2 milestone.

@efortuna
Copy link
Contributor

efortuna commented Feb 5, 2014

Set owner to @efortuna.

@efortuna
Copy link
Contributor

efortuna commented Feb 5, 2014

@efortuna
Copy link
Contributor

Issue #16778 has been merged into this issue.

@efortuna
Copy link
Contributor

After the analyzer issue is fixed we should be able to close this bug. All the other non-analyzer bug issues have been fixed I believe.


Marked this as being blocked by #16686.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@leafpetersen
Copy link
Member

Marked this as being blocked by #18596.

@efortuna
Copy link
Contributor

Marked this as being blocked by #16563.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.2 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@efortuna
Copy link
Contributor

closing as fixed at last!


Added Fixed label.

@alan-knight
Copy link
Contributor

This doesn't seem to have stayed fixed. There are 12 suppressions in analyze_library.status with this bug number associated with them, and removing them causes failures. Mostly they seem to be the issues from https://code.google.com/p/dart/issues/detail?id=16563 , implementing bool/num/etc, along with a lot of static warnings about finals not initialized and a few others, but I don't know if warnings would cause the test to fail on its own.


Removed the owner.
Removed Type-Defect, Priority-Unassigned labels.
Added Type-CodeHealth, Priority-Medium, Accepted labels.

@alan-knight
Copy link
Contributor

Issue #6985 has been merged into this issue.

@ricowind ricowind added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable Priority-Medium area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Jan 14, 2015
@ricowind ricowind added this to the Oldschool-1.6 milestone Jan 14, 2015
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on and removed accepted labels Feb 29, 2016
@vsmenon vsmenon added the area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. label Jul 20, 2019
@sigmundch sigmundch added the web-libraries Issues impacting dart:html, etc., libraries label Oct 25, 2021
@lrhn lrhn removed the area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web-js Issues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop. library-html P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

9 participants