Skip to content

Date allows hours == 24 in broken down time, but maybe should rather allow seconds == 60. #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
floitschG opened this issue Jan 12, 2012 · 2 comments
Closed

Date allows hours == 24 in broken down time, but maybe should rather allow seconds == 60. #1154

floitschG opened this issue Jan 12, 2012 · 2 comments
Assignees
@floitschG
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-duplicate Closed in favor of an existing report

Comments

@floitschG
Copy link
Contributor

Date brokenDownDateToMillisecondsSinceEpoch allows hours to be 24 (in case there was a leap-second).
The Linux API however rather wants seconds==60 in this case (and restrict the hours-range to 0-23).
The 24h thing probably came from JS (to be verified). In any case we have to check this.
Also touches the Lib.
@iposva-google
Copy link
Contributor

Added Accepted label.

@floitschG
Copy link
Contributor Author

The date class should not deal with leap seconds.
We should either remove support for 24hours (or 60 seconds) or allow over- and underflows of the arguments.
Closing as duplicate of the latter (bug 2771).

Added Duplicate label.
Marked as being merged into #2771.

@floitschG floitschG added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-duplicate Closed in favor of an existing report labels Jun 18, 2012
@floitschG floitschG self-assigned this Jun 18, 2012
@floitschG floitschG mentioned this issue Jun 3, 2015
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@floitschG floitschG

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. closed-duplicate Closed in favor of an existing report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iposva-google @floitschG