ErrorReporter. Remove empty 'arguments' arguments.

scheglov · Commit Queue · commit f95441f707d1 · 2024-02-02T16:55:00.000Z
Change-Id: I70251ec7872162f148dc6a4b5feae99faa175890 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/349632 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
diff --git a/pkg/analyzer/lib/src/dart/constant/constant_verifier.dart b/pkg/analyzer/lib/src/dart/constant/constant_verifier.dart
@@ -179,7 +179,6 @@ class ConstantVerifier extends RecursiveAstVisitor<void> {
         _errorReporter.atNode(
           node.returnType,
           CompileTimeErrorCode.RECURSIVE_CONSTANT_CONSTRUCTOR,
-          arguments: [],
         );
       }
 
@@ -953,7 +952,6 @@ class ConstantVerifier extends RecursiveAstVisitor<void> {
             errorBuffer.toString(),
             correctionTextBuffer.toString(),
           ],
-          messages: [],
           data: correctionDataBuffer.isComplete
               ? correctionDataBuffer.parts
               : null,
diff --git a/pkg/analyzer/lib/src/dart/constant/evaluation.dart b/pkg/analyzer/lib/src/dart/constant/evaluation.dart
@@ -368,7 +368,6 @@ class ConstantEvaluationEngine {
       final errorNode = configuration.errorNode(node);
       result = InvalidConstant.forEntity(
           errorNode, CompileTimeErrorCode.CONST_EVAL_THROWS_EXCEPTION,
-          arguments: [],
           contextMessages: [...result.contextMessages, contextMessage]);
     }
 
diff --git a/pkg/analyzer/lib/src/dart/resolver/assignment_expression_resolver.dart b/pkg/analyzer/lib/src/dart/resolver/assignment_expression_resolver.dart
@@ -147,7 +147,6 @@ class AssignmentExpressionResolver {
         _errorReporter.atNode(
           right,
           CompileTimeErrorCode.RECORD_LITERAL_ONE_POSITIONAL_NO_TRAILING_COMMA,
-          arguments: [],
         );
         return;
       }
@@ -178,13 +177,11 @@ class AssignmentExpressionResolver {
       _errorReporter.atNode(
         methodName,
         CompileTimeErrorCode.USE_OF_VOID_RESULT,
-        arguments: [],
       );
     } else {
       _errorReporter.atNode(
         expression,
         CompileTimeErrorCode.USE_OF_VOID_RESULT,
-        arguments: [],
       );
     }
 
diff --git a/pkg/analyzer/lib/src/dart/resolver/constructor_reference_resolver.dart b/pkg/analyzer/lib/src/dart/resolver/constructor_reference_resolver.dart
@@ -26,7 +26,6 @@ class ConstructorReferenceResolver {
       _resolver.errorReporter.atNode(
         node,
         WarningCode.SDK_VERSION_CONSTRUCTOR_TEAROFFS,
-        arguments: [],
       );
     }
     node.constructorName.accept(_resolver);
@@ -38,7 +37,6 @@ class ConstructorReferenceResolver {
           node,
           CompileTimeErrorCode
               .TEAROFF_OF_GENERATIVE_CONSTRUCTOR_OF_ABSTRACT_CLASS,
-          arguments: [],
         );
       }
     }
diff --git a/pkg/analyzer/lib/src/dart/resolver/function_expression_invocation_resolver.dart b/pkg/analyzer/lib/src/dart/resolver/function_expression_invocation_resolver.dart
@@ -128,13 +128,11 @@ class FunctionExpressionInvocationResolver {
       _errorReporter.atNode(
         methodName,
         CompileTimeErrorCode.USE_OF_VOID_RESULT,
-        arguments: [],
       );
     } else {
       _errorReporter.atNode(
         expression,
         CompileTimeErrorCode.USE_OF_VOID_RESULT,
-        arguments: [],
       );
     }
 
diff --git a/pkg/analyzer/lib/src/dart/resolver/function_reference_resolver.dart b/pkg/analyzer/lib/src/dart/resolver/function_reference_resolver.dart
@@ -105,7 +105,6 @@ class FunctionReferenceResolver {
       _errorReporter.atNode(
         function,
         CompileTimeErrorCode.GENERIC_METHOD_TYPE_INSTANTIATION_ON_DYNAMIC,
-        arguments: [],
       );
       node.staticType = InvalidTypeImpl.instance;
       return true;
@@ -275,7 +274,6 @@ class FunctionReferenceResolver {
         _errorReporter.atNode(
           node.function,
           CompileTimeErrorCode.DISALLOWED_TYPE_INSTANTIATION_EXPRESSION,
-          arguments: [],
         );
         node.staticType = InvalidTypeImpl.instance;
       } else if (rawType is DynamicType) {
@@ -341,7 +339,6 @@ class FunctionReferenceResolver {
       _errorReporter.atNode(
         node.function,
         CompileTimeErrorCode.DISALLOWED_TYPE_INSTANTIATION_EXPRESSION,
-        arguments: [],
       );
     }
     _resolve(node: node, rawType: rawType);
@@ -495,7 +492,6 @@ class FunctionReferenceResolver {
       _errorReporter.atNode(
         function.identifier,
         CompileTimeErrorCode.DISALLOWED_TYPE_INSTANTIATION_EXPRESSION,
-        arguments: [],
       );
     }
     function.accept(_resolver);
@@ -537,7 +533,6 @@ class FunctionReferenceResolver {
         _errorReporter.atNode(
           node,
           CompileTimeErrorCode.GENERIC_METHOD_TYPE_INSTANTIATION_ON_DYNAMIC,
-          arguments: [],
         );
         node.staticType = InvalidTypeImpl.instance;
         return;
@@ -565,7 +560,6 @@ class FunctionReferenceResolver {
         _errorReporter.atNode(
           function.propertyName,
           CompileTimeErrorCode.DISALLOWED_TYPE_INSTANTIATION_EXPRESSION,
-          arguments: [],
         );
       }
 
diff --git a/pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart b/pkg/analyzer/lib/src/dart/resolver/resolution_visitor.dart
@@ -977,7 +977,6 @@ class ResolutionVisitor extends RecursiveAstVisitor<void> {
         _errorReporter.atNode(
           node,
           WarningCode.SDK_VERSION_CONSTRUCTOR_TEAROFFS,
-          arguments: [],
         );
       }
       return newNode.accept(this);
diff --git a/pkg/analyzer/lib/src/error/annotation_verifier.dart b/pkg/analyzer/lib/src/error/annotation_verifier.dart
@@ -80,7 +80,6 @@ class AnnotationVerifier {
       _errorReporter.atNode(
         node,
         WarningCode.INVALID_FACTORY_ANNOTATION,
-        arguments: [],
       );
       return;
     }
@@ -135,7 +134,6 @@ class AnnotationVerifier {
       _errorReporter.atNode(
         node,
         WarningCode.INVALID_IMMUTABLE_ANNOTATION,
-        arguments: [],
       );
     }
   }
@@ -153,7 +151,6 @@ class AnnotationVerifier {
           _errorReporter.atNode(
             variable,
             WarningCode.INVALID_INTERNAL_ANNOTATION,
-            arguments: [],
           );
         }
       }
@@ -164,7 +161,6 @@ class AnnotationVerifier {
           _errorReporter.atNode(
             variable,
             WarningCode.INVALID_INTERNAL_ANNOTATION,
-            arguments: [],
           );
         }
       }
@@ -174,20 +170,17 @@ class AnnotationVerifier {
         _errorReporter.atNode(
           node,
           WarningCode.INVALID_INTERNAL_ANNOTATION,
-          arguments: [],
         );
       }
     } else if (parentElementIsPrivate) {
       _errorReporter.atNode(
         node,
         WarningCode.INVALID_INTERNAL_ANNOTATION,
-        arguments: [],
       );
     } else if (_inPackagePublicApi) {
       _errorReporter.atNode(
         node,
         WarningCode.INVALID_INTERNAL_ANNOTATION,
-        arguments: [],
       );
     }
   }
@@ -229,7 +222,6 @@ class AnnotationVerifier {
       _errorReporter.atNode(
         node,
         WarningCode.INVALID_LITERAL_ANNOTATION,
-        arguments: [],
       );
     }
   }
diff --git a/pkg/analyzer/lib/src/error/best_practices_verifier.dart b/pkg/analyzer/lib/src/error/best_practices_verifier.dart
@@ -269,7 +269,6 @@ class BestPracticesVerifier extends RecursiveAstVisitor<void> {
       _errorReporter.atToken(
         newKeyword,
         WarningCode.DEPRECATED_NEW_IN_COMMENT_REFERENCE,
-        arguments: [],
       );
     }
     super.visitCommentReference(node);
diff --git a/pkg/analyzer/lib/src/error/return_type_verifier.dart b/pkg/analyzer/lib/src/error/return_type_verifier.dart
@@ -356,7 +356,6 @@ class ReturnTypeVerifier {
               expression,
               CompileTimeErrorCode
                   .RECORD_LITERAL_ONE_POSITIONAL_NO_TRAILING_COMMA,
-              arguments: [],
             );
             return;
           }
diff --git a/pkg/analyzer/lib/src/generated/error_detection_helpers.dart b/pkg/analyzer/lib/src/generated/error_detection_helpers.dart
@@ -98,7 +98,6 @@ mixin ErrorDetectionHelpers {
             expression,
             CompileTimeErrorCode
                 .RECORD_LITERAL_ONE_POSITIONAL_NO_TRAILING_COMMA,
-            arguments: [],
           );
           return;
         }
@@ -239,13 +238,11 @@ mixin ErrorDetectionHelpers {
       errorReporter.atNode(
         methodName,
         CompileTimeErrorCode.USE_OF_VOID_RESULT,
-        arguments: [],
       );
     } else {
       errorReporter.atNode(
         expression,
         CompileTimeErrorCode.USE_OF_VOID_RESULT,
-        arguments: [],
       );
     }
 
diff --git a/pkg/analyzer/lib/src/generated/error_verifier.dart b/pkg/analyzer/lib/src/generated/error_verifier.dart
@@ -6414,7 +6414,6 @@ class _UninstantiatedBoundChecker extends RecursiveAstVisitor<void> {
       _errorReporter.atNode(
         node,
         CompileTimeErrorCode.NOT_INSTANTIATED_BOUND,
-        arguments: [],
       );
     }
   }
diff --git a/pkg/analyzer/lib/src/generated/ffi_verifier.dart b/pkg/analyzer/lib/src/generated/ffi_verifier.dart
@@ -272,7 +272,6 @@ class FfiVerifier extends RecursiveAstVisitor<void> {
             _errorReporter.atNode(
               name,
               FfiCode.FFI_NATIVE_INVALID_DUPLICATE_DEFAULT_ASSET,
-              arguments: [],
             );
           }
 
@@ -418,7 +417,6 @@ class FfiVerifier extends RecursiveAstVisitor<void> {
         _errorReporter.atNode(
           name,
           FfiCode.FFI_NATIVE_INVALID_MULTIPLE_ANNOTATIONS,
-          arguments: [],
         );
         break;
       }

Original file line number	Diff line number	Diff line change
`@@ -368,7 +368,6 @@ class ConstantEvaluationEngine {`
`368`	`368`	`final errorNode = configuration.errorNode(node);`
`369`	`369`	`result = InvalidConstant.forEntity(`
`370`	`370`	`errorNode, CompileTimeErrorCode.CONST_EVAL_THROWS_EXCEPTION,`
`371`		`- arguments: [],`
`372`	`371`	`contextMessages: [...result.contextMessages, contextMessage]);`
`373`	`372`	`}`
`374`	`373`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@ class ConstructorReferenceResolver {`
`26`	`26`	`_resolver.errorReporter.atNode(`
`27`	`27`	`node,`
`28`	`28`	`WarningCode.SDK_VERSION_CONSTRUCTOR_TEAROFFS,`
`29`		`- arguments: [],`
`30`	`29`	`);`
`31`	`30`	`}`
`32`	`31`	`node.constructorName.accept(_resolver);`
`@@ -38,7 +37,6 @@ class ConstructorReferenceResolver {`
`38`	`37`	`node,`
`39`	`38`	`CompileTimeErrorCode`
`40`	`39`	`.TEAROFF_OF_GENERATIVE_CONSTRUCTOR_OF_ABSTRACT_CLASS,`
`41`		`- arguments: [],`
`42`	`40`	`);`
`43`	`41`	`}`
`44`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -977,7 +977,6 @@ class ResolutionVisitor extends RecursiveAstVisitor<void> {`
`977`	`977`	`_errorReporter.atNode(`
`978`	`978`	`node,`
`979`	`979`	`WarningCode.SDK_VERSION_CONSTRUCTOR_TEAROFFS,`
`980`		`- arguments: [],`
`981`	`980`	`);`
`982`	`981`	`}`
`983`	`982`	`return newNode.accept(this);`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,6 @@ class AnnotationVerifier {`
`80`	`80`	`_errorReporter.atNode(`
`81`	`81`	`node,`
`82`	`82`	`WarningCode.INVALID_FACTORY_ANNOTATION,`
`83`		`- arguments: [],`
`84`	`83`	`);`
`85`	`84`	`return;`
`86`	`85`	`}`
`@@ -135,7 +134,6 @@ class AnnotationVerifier {`
`135`	`134`	`_errorReporter.atNode(`
`136`	`135`	`node,`
`137`	`136`	`WarningCode.INVALID_IMMUTABLE_ANNOTATION,`
`138`		`- arguments: [],`
`139`	`137`	`);`
`140`	`138`	`}`
`141`	`139`	`}`
`@@ -153,7 +151,6 @@ class AnnotationVerifier {`
`153`	`151`	`_errorReporter.atNode(`
`154`	`152`	`variable,`
`155`	`153`	`WarningCode.INVALID_INTERNAL_ANNOTATION,`
`156`		`- arguments: [],`
`157`	`154`	`);`
`158`	`155`	`}`
`159`	`156`	`}`
`@@ -164,7 +161,6 @@ class AnnotationVerifier {`
`164`	`161`	`_errorReporter.atNode(`
`165`	`162`	`variable,`
`166`	`163`	`WarningCode.INVALID_INTERNAL_ANNOTATION,`
`167`		`- arguments: [],`
`168`	`164`	`);`
`169`	`165`	`}`
`170`	`166`	`}`
`@@ -174,20 +170,17 @@ class AnnotationVerifier {`
`174`	`170`	`_errorReporter.atNode(`
`175`	`171`	`node,`
`176`	`172`	`WarningCode.INVALID_INTERNAL_ANNOTATION,`
`177`		`- arguments: [],`
`178`	`173`	`);`
`179`	`174`	`}`
`180`	`175`	`} else if (parentElementIsPrivate) {`
`181`	`176`	`_errorReporter.atNode(`
`182`	`177`	`node,`
`183`	`178`	`WarningCode.INVALID_INTERNAL_ANNOTATION,`
`184`		`- arguments: [],`
`185`	`179`	`);`
`186`	`180`	`} else if (_inPackagePublicApi) {`
`187`	`181`	`_errorReporter.atNode(`
`188`	`182`	`node,`
`189`	`183`	`WarningCode.INVALID_INTERNAL_ANNOTATION,`
`190`		`- arguments: [],`
`191`	`184`	`);`
`192`	`185`	`}`
`193`	`186`	`}`
`@@ -229,7 +222,6 @@ class AnnotationVerifier {`
`229`	`222`	`_errorReporter.atNode(`
`230`	`223`	`node,`
`231`	`224`	`WarningCode.INVALID_LITERAL_ANNOTATION,`
`232`		`- arguments: [],`
`233`	`225`	`);`
`234`	`226`	`}`
`235`	`227`	`}`
Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,6 @@ class BestPracticesVerifier extends RecursiveAstVisitor<void> {`
`269`	`269`	`_errorReporter.atToken(`
`270`	`270`	`newKeyword,`
`271`	`271`	`WarningCode.DEPRECATED_NEW_IN_COMMENT_REFERENCE,`
`272`		`- arguments: [],`
`273`	`272`	`);`
`274`	`273`	`}`
`275`	`274`	`super.visitCommentReference(node);`
Original file line number	Diff line number	Diff line change
`@@ -356,7 +356,6 @@ class ReturnTypeVerifier {`
`356`	`356`	`expression,`
`357`	`357`	`CompileTimeErrorCode`
`358`	`358`	`.RECORD_LITERAL_ONE_POSITIONAL_NO_TRAILING_COMMA,`
`359`		`- arguments: [],`
`360`	`359`	`);`
`361`	`360`	`return;`
`362`	`361`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6414,7 +6414,6 @@ class _UninstantiatedBoundChecker extends RecursiveAstVisitor<void> {`
`6414`	`6414`	`_errorReporter.atNode(`
`6415`	`6415`	`node,`
`6416`	`6416`	`CompileTimeErrorCode.NOT_INSTANTIATED_BOUND,`
`6417`		`- arguments: [],`
`6418`	`6417`	`);`
`6419`	`6418`	`}`
`6420`	`6419`	`}`
Original file line number	Diff line number	Diff line change
`@@ -272,7 +272,6 @@ class FfiVerifier extends RecursiveAstVisitor<void> {`
`272`	`272`	`_errorReporter.atNode(`
`273`	`273`	`name,`
`274`	`274`	`FfiCode.FFI_NATIVE_INVALID_DUPLICATE_DEFAULT_ASSET,`
`275`		`- arguments: [],`
`276`	`275`	`);`
`277`	`276`	`}`
`278`	`277`
`@@ -418,7 +417,6 @@ class FfiVerifier extends RecursiveAstVisitor<void> {`
`418`	`417`	`_errorReporter.atNode(`
`419`	`418`	`name,`
`420`	`419`	`FfiCode.FFI_NATIVE_INVALID_MULTIPLE_ANNOTATIONS,`
`421`		`- arguments: [],`
`422`	`420`	`);`
`423`	`421`	`break;`
`424`	`422`	`}`