[analyzer][cfe] Generate constraints based on type variable bounds

In response to dart-lang/language#3009

Change-Id: I918d392e422f1997736bf2543c8107cb44d3d6f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/364721
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Michael Thomsen <[email protected]>
Reviewed-by: Paul Berry <[email protected]>

Author: chloestefantsova

pkg/_fe_analyzer_shared/lib/src/experiments/flags.dart

@@ -108,6 +108,13 @@ enum ExperimentalFlag {
       experimentEnabledVersion: const Version(3, 4),
       experimentReleasedVersion: const Version(3, 4)),
 
+  inferenceUsingBounds(
+      name: 'inference-using-bounds',
+      isEnabledByDefault: false,
+      isExpired: false,
+      experimentEnabledVersion: defaultLanguageVersion,
+      experimentReleasedVersion: defaultLanguageVersion),
+
   inlineClass(
       name: 'inline-class',
       isEnabledByDefault: true,

pkg/analyzer/lib/dart/analysis/features.dart

@@ -43,6 +43,10 @@ abstract class Feature {
   /// Feature information for generic metadata.
   static final generic_metadata = ExperimentalFeatures.generic_metadata;
 
+  /// Feature information for inference using bounds.
+  static final inference_using_bounds =
+      ExperimentalFeatures.inference_using_bounds;
+
   /// Feature information for inference-update-1.
   static final inference_update_1 = ExperimentalFeatures.inference_update_1;
 

pkg/analyzer/lib/src/dart/analysis/experiments.g.dart

@@ -31,6 +31,8 @@ final _knownFeatures = <String, ExperimentalFeature>{
   EnableString.inference_update_1: ExperimentalFeatures.inference_update_1,
   EnableString.inference_update_2: ExperimentalFeatures.inference_update_2,
   EnableString.inference_update_3: ExperimentalFeatures.inference_update_3,
+  EnableString.inference_using_bounds:
+      ExperimentalFeatures.inference_using_bounds,
   EnableString.inline_class: ExperimentalFeatures.inline_class,
   EnableString.macros: ExperimentalFeatures.macros,
   EnableString.named_arguments_anywhere:
@@ -100,6 +102,9 @@ class EnableString {
   /// String to enable the experiment "inference-update-3"
   static const String inference_update_3 = 'inference-update-3';
 
+  /// String to enable the experiment "inference-using-bounds"
+  static const String inference_using_bounds = 'inference-using-bounds';
+
   /// String to enable the experiment "inline-class"
   static const String inline_class = 'inline-class';
 
@@ -307,8 +312,19 @@ class ExperimentalFeatures {
     releaseVersion: Version.parse('3.4.0'),
   );
 
-  static final inline_class = ExperimentalFeature(
+  static final inference_using_bounds = ExperimentalFeature(
     index: 14,
+    enableString: EnableString.inference_using_bounds,
+    isEnabledByDefault: IsEnabledByDefault.inference_using_bounds,
+    isExpired: IsExpired.inference_using_bounds,
+    documentation:
+        'Use type parameter bounds more extensively in type inference.',
+    experimentalReleaseVersion: null,
+    releaseVersion: null,
+  );
+
+  static final inline_class = ExperimentalFeature(
+    index: 15,
     enableString: EnableString.inline_class,
     isEnabledByDefault: IsEnabledByDefault.inline_class,
     isExpired: IsExpired.inline_class,
@@ -318,7 +334,7 @@ class ExperimentalFeatures {
   );
 
   static final macros = ExperimentalFeature(
-    index: 15,
+    index: 16,
     enableString: EnableString.macros,
     isEnabledByDefault: IsEnabledByDefault.macros,
     isExpired: IsExpired.macros,
@@ -328,7 +344,7 @@ class ExperimentalFeatures {
   );
 
   static final named_arguments_anywhere = ExperimentalFeature(
-    index: 16,
+    index: 17,
     enableString: EnableString.named_arguments_anywhere,
     isEnabledByDefault: IsEnabledByDefault.named_arguments_anywhere,
     isExpired: IsExpired.named_arguments_anywhere,
@@ -338,7 +354,7 @@ class ExperimentalFeatures {
   );
 
   static final native_assets = ExperimentalFeature(
-    index: 17,
+    index: 18,
     enableString: EnableString.native_assets,
     isEnabledByDefault: IsEnabledByDefault.native_assets,
     isExpired: IsExpired.native_assets,
@@ -348,7 +364,7 @@ class ExperimentalFeatures {
   );
 
   static final non_nullable = ExperimentalFeature(
-    index: 18,
+    index: 19,
     enableString: EnableString.non_nullable,
     isEnabledByDefault: IsEnabledByDefault.non_nullable,
     isExpired: IsExpired.non_nullable,
@@ -358,7 +374,7 @@ class ExperimentalFeatures {
   );
 
   static final nonfunction_type_aliases = ExperimentalFeature(
-    index: 19,
+    index: 20,
     enableString: EnableString.nonfunction_type_aliases,
     isEnabledByDefault: IsEnabledByDefault.nonfunction_type_aliases,
     isExpired: IsExpired.nonfunction_type_aliases,
@@ -368,7 +384,7 @@ class ExperimentalFeatures {
   );
 
   static final null_aware_elements = ExperimentalFeature(
-    index: 20,
+    index: 21,
     enableString: EnableString.null_aware_elements,
     isEnabledByDefault: IsEnabledByDefault.null_aware_elements,
     isExpired: IsExpired.null_aware_elements,
@@ -378,7 +394,7 @@ class ExperimentalFeatures {
   );
 
   static final patterns = ExperimentalFeature(
-    index: 21,
+    index: 22,
     enableString: EnableString.patterns,
     isEnabledByDefault: IsEnabledByDefault.patterns,
     isExpired: IsExpired.patterns,
@@ -388,7 +404,7 @@ class ExperimentalFeatures {
   );
 
   static final record_use = ExperimentalFeature(
-    index: 22,
+    index: 23,
     enableString: EnableString.record_use,
     isEnabledByDefault: IsEnabledByDefault.record_use,
     isExpired: IsExpired.record_use,
@@ -398,7 +414,7 @@ class ExperimentalFeatures {
   );
 
   static final records = ExperimentalFeature(
-    index: 23,
+    index: 24,
     enableString: EnableString.records,
     isEnabledByDefault: IsEnabledByDefault.records,
     isExpired: IsExpired.records,
@@ -408,7 +424,7 @@ class ExperimentalFeatures {
   );
 
   static final sealed_class = ExperimentalFeature(
-    index: 24,
+    index: 25,
     enableString: EnableString.sealed_class,
     isEnabledByDefault: IsEnabledByDefault.sealed_class,
     isExpired: IsExpired.sealed_class,
@@ -418,7 +434,7 @@ class ExperimentalFeatures {
   );
 
   static final set_literals = ExperimentalFeature(
-    index: 25,
+    index: 26,
     enableString: EnableString.set_literals,
     isEnabledByDefault: IsEnabledByDefault.set_literals,
     isExpired: IsExpired.set_literals,
@@ -428,7 +444,7 @@ class ExperimentalFeatures {
   );
 
   static final spread_collections = ExperimentalFeature(
-    index: 26,
+    index: 27,
     enableString: EnableString.spread_collections,
     isEnabledByDefault: IsEnabledByDefault.spread_collections,
     isExpired: IsExpired.spread_collections,
@@ -438,7 +454,7 @@ class ExperimentalFeatures {
   );
 
   static final super_parameters = ExperimentalFeature(
-    index: 27,
+    index: 28,
     enableString: EnableString.super_parameters,
     isEnabledByDefault: IsEnabledByDefault.super_parameters,
     isExpired: IsExpired.super_parameters,
@@ -448,7 +464,7 @@ class ExperimentalFeatures {
   );
 
   static final test_experiment = ExperimentalFeature(
-    index: 28,
+    index: 29,
     enableString: EnableString.test_experiment,
     isEnabledByDefault: IsEnabledByDefault.test_experiment,
     isExpired: IsExpired.test_experiment,
@@ -459,7 +475,7 @@ class ExperimentalFeatures {
   );
 
   static final triple_shift = ExperimentalFeature(
-    index: 29,
+    index: 30,
     enableString: EnableString.triple_shift,
     isEnabledByDefault: IsEnabledByDefault.triple_shift,
     isExpired: IsExpired.triple_shift,
@@ -469,7 +485,7 @@ class ExperimentalFeatures {
   );
 
   static final unnamed_libraries = ExperimentalFeature(
-    index: 30,
+    index: 31,
     enableString: EnableString.unnamed_libraries,
     isEnabledByDefault: IsEnabledByDefault.unnamed_libraries,
     isExpired: IsExpired.unnamed_libraries,
@@ -479,7 +495,7 @@ class ExperimentalFeatures {
   );
 
   static final unquoted_imports = ExperimentalFeature(
-    index: 31,
+    index: 32,
     enableString: EnableString.unquoted_imports,
     isEnabledByDefault: IsEnabledByDefault.unquoted_imports,
     isExpired: IsExpired.unquoted_imports,
@@ -489,7 +505,7 @@ class ExperimentalFeatures {
   );
 
   static final variance = ExperimentalFeature(
-    index: 32,
+    index: 33,
     enableString: EnableString.variance,
     isEnabledByDefault: IsEnabledByDefault.variance,
     isExpired: IsExpired.variance,
@@ -499,7 +515,7 @@ class ExperimentalFeatures {
   );
 
   static final wildcard_variables = ExperimentalFeature(
-    index: 33,
+    index: 34,
     enableString: EnableString.wildcard_variables,
     isEnabledByDefault: IsEnabledByDefault.wildcard_variables,
     isExpired: IsExpired.wildcard_variables,
@@ -555,6 +571,9 @@ class IsEnabledByDefault {
   /// Default state of the experiment "inference-update-3"
   static const bool inference_update_3 = true;
 
+  /// Default state of the experiment "inference-using-bounds"
+  static const bool inference_using_bounds = false;
+
   /// Default state of the experiment "inline-class"
   static const bool inline_class = true;
 
@@ -662,6 +681,9 @@ class IsExpired {
   /// Expiration status of the experiment "inference-update-3"
   static const bool inference_update_3 = true;
 
+  /// Expiration status of the experiment "inference-using-bounds"
+  static const bool inference_using_bounds = false;
+
   /// Expiration status of the experiment "inline-class"
   static const bool inline_class = true;
 
@@ -773,6 +795,10 @@ mixin _CurrentState {
   bool get inference_update_3 =>
       isEnabled(ExperimentalFeatures.inference_update_3);
 
+  /// Current state for the flag "inference-using-bounds"
+  bool get inference_using_bounds =>
+      isEnabled(ExperimentalFeatures.inference_using_bounds);
+
   /// Current state for the flag "inline-class"
   bool get inline_class => isEnabled(ExperimentalFeatures.inline_class);