[cfe] Reuse InferenceVisitor on recursive calls

This moves inferExpression and inferStatement from TypeInferrer to
InferenceVisitor and reuses the visitor throughout the inference.

Change-Id: Ieea1084a51998f8f5f351d7cdecf5b907108971e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247969
Reviewed-by: Chloe Stefantsova <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>

Author: johnniwinther

pkg/front_end/lib/src/fasta/kernel/benchmarker.dart

@@ -236,14 +236,14 @@ enum BenchmarkSubdivides {
 
   inferConstructorParameterTypes,
   inferDeclarationType,
-  inferExpression,
+  inferImplicitFieldType,
   inferFieldInitializer,
   inferFunctionBody,
   inferInitializer,
   inferMetadata,
   inferMetadataKeepingHelper,
   inferParameterInitializer,
-  inferInvocation,
+  inferRedirectingFactoryTypeArguments,
 
   buildOutlineExpressions,
   delayedActionPerformer,

pkg/front_end/lib/src/fasta/kernel/implicit_field_type.dart

@@ -17,7 +17,6 @@ import '../problems.dart' show unsupported;
 import '../builder/builder.dart';
 import '../source/source_field_builder.dart';
 import '../type_inference/type_inferrer.dart';
-import '../type_inference/type_schema.dart';
 import 'body_builder.dart';
 
 abstract class ImplicitFieldType extends DartType {
@@ -162,10 +161,7 @@ class _ImplicitFieldTypeRoot extends ImplicitFieldType {
           bodyBuilder.parseFieldInitializer(initializerToken!);
       initializerToken = null;
 
-      ExpressionInferenceResult result = typeInferrer.inferExpression(
-          initializer, const UnknownType(), true,
-          isVoidAllowed: true);
-      inferredType = typeInferrer.inferDeclarationType(result.inferredType);
+      inferredType = typeInferrer.inferImplicitFieldType(initializer);
     } else {
       inferredType = const DynamicType();
     }