More tweaks in attempt to debug the reason of failing getNavigation() tests.

[email protected]
BUG=

Review URL: https://codereview.chromium.org//1284933002 .

Author: scheglov

pkg/analysis_server/lib/src/domain_analysis.dart

@@ -118,38 +118,46 @@ class AnalysisDomainHandler implements RequestHandler {
       return new Response.getNavigationInvalidFile(request);
     }
     analysisFuture.then((AnalysisDoneReason reason) {
-      switch (reason) {
-        case AnalysisDoneReason.COMPLETE:
-          print('AnalysisDoneReason.COMPLETE');
-          List<CompilationUnit> units =
-              server.getResolvedCompilationUnits(file);
-          print('units: $units');
-          if (units.isEmpty) {
-            server.sendResponse(new Response.getNavigationInvalidFile(request));
-          } else {
-            DartUnitNavigationComputer computer =
-                new DartUnitNavigationComputer();
-            _GetNavigationAstVisitor visitor = new _GetNavigationAstVisitor(
-                params.offset, params.offset + params.length, computer);
-            for (CompilationUnit unit in units) {
-              unit.accept(visitor);
+      print('  reason: $reason');
+      try {
+        switch (reason) {
+          case AnalysisDoneReason.COMPLETE:
+            print('  AnalysisDoneReason.COMPLETE');
+            List<CompilationUnit> units =
+                server.getResolvedCompilationUnits(file);
+            print('  units: $units');
+            if (units.isEmpty) {
+              server
+                  .sendResponse(new Response.getNavigationInvalidFile(request));
+            } else {
+              DartUnitNavigationComputer computer =
+                  new DartUnitNavigationComputer();
+              _GetNavigationAstVisitor visitor = new _GetNavigationAstVisitor(
+                  params.offset, params.offset + params.length, computer);
+              for (CompilationUnit unit in units) {
+                unit.accept(visitor);
+              }
+              server.sendResponse(new AnalysisGetNavigationResult(
+                      computer.files, computer.targets, computer.regions)
+                  .toResponse(request.id));
             }
-            server.sendResponse(new AnalysisGetNavigationResult(
-                    computer.files, computer.targets, computer.regions)
-                .toResponse(request.id));
-          }
-          break;
-        case AnalysisDoneReason.CONTEXT_REMOVED:
-          print('AnalysisDoneReason.CONTEXT_REMOVED');
-          // The active contexts have changed, so try again.
-          Response response = getNavigation(request);
-          if (response != Response.DELAYED_RESPONSE) {
-            server.sendResponse(response);
-          }
-          break;
+            break;
+          case AnalysisDoneReason.CONTEXT_REMOVED:
+            print('  AnalysisDoneReason.CONTEXT_REMOVED');
+            // The active contexts have changed, so try again.
+            Response response = getNavigation(request);
+            if (response != Response.DELAYED_RESPONSE) {
+              server.sendResponse(response);
+            }
+            break;
+        }
+      } on Exception catch (e, st) {
+        print('Exception1 in AnalysisDomainHandler.getNavigation()');
+        print(e);
+        print(st);
       }
     }).catchError((e, st) {
-      print('Exception in AnalysisDomainHandler.getNavigation()');
+      print('Exception2 in AnalysisDomainHandler.getNavigation()');
       print(e);
       print(st);
     });

pkg/analysis_server/test/analysis/get_navigation_test.dart

@@ -30,6 +30,7 @@ class GetNavigationTest extends AbstractNavigationTest {
   }
 
   test_beforeAnalysisComplete() async {
+    print('+++test_beforeAnalysisComplete');
     addTestFile('''
 main() {
   var test = 0;
@@ -42,11 +43,13 @@ main() {
   }
 
   test_fileDoesNotExist() {
+    print('+++test_fileDoesNotExist');
     String file = '$projectPath/doesNotExist.dart';
     return _checkInvalid(file, -1, -1);
   }
 
   test_fileWithoutContext() {
+    print('+++test_fileWithoutContext');
     String file = '/outside.dart';
     addFile(
         file,
@@ -59,6 +62,7 @@ main() {
   }
 
   test_multipleRegions() async {
+    print('+++test_multipleRegions');
     addTestFile('''
 main() {
   var aaa = 1;
@@ -89,6 +93,7 @@ main() {
   }
 
   test_removeContextAfterRequest() async {
+    print('+++test_removeContextAfterRequest');
     addTestFile('''
 main() {
   var test = 0;
@@ -111,6 +116,7 @@ main() {
   }
 
   test_zeroLength_end() async {
+    print('+++test_zeroLength_end');
     addTestFile('''
 main() {
   var test = 0;
@@ -124,6 +130,7 @@ main() {
   }
 
   test_zeroLength_start() async {
+    print('+++test_zeroLength_start');
     addTestFile('''
 main() {
   var test = 0;

pkg/analysis_server/test/mocks.dart

@@ -58,7 +58,7 @@ Matcher isResponseSuccess(String id) => new _IsResponseSuccess(id);
  * times. By default, this should pump the event queue enough times to allow
  * any code to run, as long as it's not waiting on some external event.
  */
-Future pumpEventQueue([int times = 500]) {
+Future pumpEventQueue([int times = 5000]) {
   if (times == 0) return new Future.value();
   // We use a delayed future to allow microtask events to finish. The
   // Future.value or Future() constructors use scheduleMicrotask themselves and
@@ -229,8 +229,8 @@ class MockServerChannel implements ServerCommunicationChannel {
   @override
   void listen(void onRequest(Request request),
       {Function onError, void onDone()}) {
-    requestController.stream.listen(onRequest,
-        onError: onError, onDone: onDone);
+    requestController.stream
+        .listen(onRequest, onError: onError, onDone: onDone);
   }
 
   @override
@@ -330,8 +330,8 @@ class MockSocket<T> implements WebSocket {
       controller.close().then((_) => twin.controller.close());
 
   StreamSubscription<T> listen(void onData(T event),
-      {Function onError, void onDone(), bool cancelOnError}) => stream.listen(
-          onData,
+          {Function onError, void onDone(), bool cancelOnError}) =>
+      stream.listen(onData,
           onError: onError, onDone: onDone, cancelOnError: cancelOnError);
 
   noSuchMethod(Invocation invocation) => super.noSuchMethod(invocation);