Version 1.19.0-dev.7.0

Merge 0b4fe48 into dev

Author: whesse

CHANGELOG.md

@@ -8,13 +8,68 @@
  reordering lines. For details, see SDK issue
  [26644](https://github.com/dart-lang/sdk/issues/26644).
 
-### Core library changes
+### Tool Changes
 
-* `dart:io`
-  * `Socket.connect` with source-address argument is now non-blocking
-    on Mac. Was already non-blocking on all other platforms.
-  * Report a better error when a bind fails because of a bad source address.
-  * Handle HTTP header `charset` parameter with empty value.
+* `dartfmt` - upgraded to v0.2.9+1
+  * Support trailing commas in argument and parameter lists.
+  * Gracefully handle read-only files.
+  * About a dozen other bug fixes.
+
+* Pub
+  * Added a `--no-packages-dir` flag to `pub get`, `pub upgrade`, and `pub
+    downgrade`. When this flag is passed, pub will not generate a `packages/`
+    directory, and will remove that directory and any symlinks to it if they
+    exist. Note that this replaces the unsupported `--no-package-symlinks` flag.
+
+  * Added the ability for packages to declare a constraint on the [Flutter][]
+    SDK:
+
+    ```yaml
+    environment:
+      flutter: ^0.1.2
+      sdk: >=1.19.0 <2.0.0
+    ```
+
+    A Flutter constraint will only be satisfiable when pub is running in the
+    context of the `flutter` executable, and when the Flutter SDK version
+    matches the constraint.
+
+  * Added `sdk` as a new package source that fetches packages from a hard-coded
+    SDK. Currently only the `flutter` SDK is supported:
+
+    ```yaml
+    dependencies:
+      flutter_driver:
+        sdk: flutter
+        version: ^0.0.1
+    ```
+
+    A Flutter `sdk` dependency will only be satisfiable when pub is running in
+    the context of the `flutter` executable, and when the Flutter SDK contains a
+    package with the given name whose version matches the constraint.
+
+  * `tar` files on Linux are now created with `0` as the user and group IDs.
+    This fixes a crash when publishing packages while using Active Directory.
+
+  * Fixed a bug where packages from a hosted HTTP URL were considered the same
+    as packages from an otherwise-identical HTTPS URL.
+
+  * Fixed timer formatting for timers that lasted longer than a minute.
+
+  * Eliminate some false negatives when determining whether global executables
+    are on the user's executable path.
+
+* `dart2js`
+  * `dart2dart` (aka `dart2js --output-type=dart`) has been removed (this was deprecated in Dart 1.11).
+
+[Flutter]: https://flutter.io/
+
+### Dart VM
+
+*   The dependency on BoringSSL has been rolled forward. Going forward, builds
+    of the Dart VM including secure sockets will require a compiler with C++11
+    support. For details, see the
+    [Building wiki page](https://github.com/dart-lang/sdk/wiki/Building).
 
 ### Strong Mode
 
@@ -89,57 +144,6 @@
 * Breaking change - sideways casts are no longer allowed
     (SDK issue [26120](https://github.com/dart-lang/sdk/issues/26120)).
 
-### Dart VM
-
-*   The dependency on BoringSSL has been rolled forward. Going forward, builds
-    of the Dart VM including secure sockets will require a compiler with C++11
-    support, and to link against glibc 2.16 or newer. For details, see the
-    [Building wiki page](https://github.com/dart-lang/sdk/wiki/Building).
-
-### Tool Changes
-
-* `dartfmt` - upgraded to v0.2.9
-  * Support trailing commas in argument and parameter lists.
-  * Gracefully handle read-only files.
-  * About a dozen other bug fixes.
-
-* Pub
-  * Added the ability for packages to declare a constraint on the [Flutter][]
-    SDK:
-
-        environment:
-          flutter: ^0.1.2
-          sdk: >=1.19.0 <2.0.0
-
-    A Flutter constraint will only be satisfiable when pub is running in the
-    context of the `flutter` executable, and when the Flutter SDK version
-    matches the constraint.
-
-  * Added `sdk` as a new package source that fetches packages from a hard-coded
-    SDK. Currently only the `flutter` SDK is supported:
-
-        dependencies:
-          flutter_driver:
-            sdk: flutter
-            version: ^0.0.1
-
-    A Flutter `sdk` dependency will only be satisfiable when pub is running in
-    the context of the `flutter` executable, and when the Flutter SDK contains a
-    package with the given name whose version matches the constraint.
-
-  * Fixed a bug where packages from a hosted HTTP URL were considered the same
-    as packages from an otherwise-identical HTTPS URL.
-
-  * Fixed timer formatting for timers that lasted longer than a minute.
-
-  * Eliminate some false negatives when determining whether global executables
-    are on the user's executable path.
-
-* dart2dart (aka `dart2js --output-type=dart`) has been removed (this was
-  deprecated in Dart 1.11)
-
-[Flutter]: https://flutter.io/
-
 ## 1.18.1 - 2016-08-02
 
 Patch release, resolves two issues and improves performance:
@@ -157,6 +161,9 @@ Patch release, resolves two issues and improves performance:
 
 ### Core library changes
 
+* `dart:core`
+  * Improved performance when parsing some common URIs.
+  * Fixed bug in `Uri.resolve` (SDK issue [26804](https://github.com/dart-lang/sdk/issues/26804)).
 * `dart:io`
   * Adds file locking modes `FileLock.BLOCKING_SHARED` and
     `FileLock.BLOCKING_EXCLUSIVE`.

DEPS

@@ -48,13 +48,13 @@ vars = {
   "chrome_rev" : "@19997",
   "cli_util_tag" : "@0.0.1+2",
   "code_transformers_rev": "@bfe9799e88d9c231747435e1c1d2495ef5ecd966",
-  "collection_tag": "@1.8.0",
+  "collection_tag": "@1.9.0",
   "convert_tag": "@2.0.0",
   "crypto_tag" : "@2.0.1",
   "csslib_tag" : "@0.12.0",
   "dart2js_info_rev" : "@0a221eaf16aec3879c45719de656680ccb80d8a1",
   "dart_services_rev" : "@7aea2574e6f3924bf409a80afb8ad52aa2be4f97",
-  "dart_style_tag": "@0.2.9",
+  "dart_style_tag": "@0.2.9+1",
   "dartdoc_tag" : "@v0.9.6+2",
   "dev_compiler_rev": "@fa084164b620ea75cd2008c9dc317655a045ad6d",
   "fixnum_tag": "@0.10.5",
@@ -71,7 +71,7 @@ vars = {
   "isolate_tag": "@0.2.2",
   "jinja2_rev": "@2222b31554f03e62600cd7e383376a7c187967a1",
   "json_rpc_2_tag": "@2.0.0",
-  "linter_rev": "@0abfb82a7d8c36946a2a9f00c699fa5a925abec3",
+  "linter_rev": "@da3ec6ae914b40332fa6b6e100c1d4aabe9e27ca",
   "logging_rev": "@85d83e002670545e9039ad3985f0018ab640e597",
   "markdown_rev": "@4aaadf3d940bb172e1f6285af4d2b1710d309982",
   "matcher_tag": "@0.12.0",
@@ -82,13 +82,14 @@ vars = {
   "observatory_pub_packages_rev": "@a01235b5b71df27b602dae4676d0bf771cbe7fa2",
   "observe_rev": "@eee2b8ec34236fa46982575fbccff84f61202ac6",
   "package_config_rev": "@1.0.0",
+  "package_resolver_tag": "@1.0.1",
   "path_tag": "@1.3.6",
   "plugin_tag": "@0.2.0",
   "ply_rev": "@604b32590ffad5cbb82e4afef1d305512d06ae93",
   "pool_tag": "@1.2.1",
   "protobuf_tag": "@0.5.1+1",
   "pub_cache_tag": "@v0.1.0",
-  "pub_rev": "@391b445dc6b28958794658b18caedb69d8cf8719",
+  "pub_rev": "@101aa44a4aebaefd0796ce44e6d155cd79fe2db4",
   "pub_semver_tag": "@1.3.0",
   "quiver_tag": "@0.21.4",
   "resource_rev":"@a49101ba2deb29c728acba6fb86000a8f730f4b1",
@@ -253,6 +254,9 @@ deps = {
   Var("dart_root") + "/third_party/pkg_tested/package_config":
       (Var("github_mirror") % "package_config") +
       Var("package_config_rev"),
+  Var("dart_root") + "/third_party/pkg_tested/package_resolver":
+      "https://github.com/dart-lang/package_resolver.git" +
+      Var("package_resolver_tag"),
   Var("dart_root") + "/third_party/pkg/path":
       (Var("github_mirror") % "path") + Var("path_tag"),
   Var("dart_root") + "/third_party/pkg/plugin":

dart.gyp

@@ -111,20 +111,6 @@
       # test suites.
       'target_name': 'dart2js_bot',
       'type': 'none',
-      'dependencies': [
-        'create_sdk',
-        'packages',
-        'try',
-      ],
-    },
-    {
-      # This is the target that is built on the dart2js debug build bots.
-      # It must depend on anything that is required by the dart2js
-      # test suites.
-      # We have this additional target because the try target takes to long
-      # to build in debug mode and will make the build step time out.
-      'target_name': 'dart2js_bot_debug',
-      'type': 'none',
       'dependencies': [
         'create_sdk',
         'packages',
@@ -150,12 +136,5 @@
         'pkg/pkg.gyp:pkg_packages',
       ],
     },
-    {
-      'target_name': 'try',
-      'type': 'none',
-      'dependencies': [
-        'site/try/build_try.gyp:try_site',
-      ],
-    },
   ],
 }

docs/language/dartLangSpec.tex

@@ -6479,15 +6479,15 @@ \subsection{ Assert}
 
 \begin{grammar}
 {\bf assertStatement:}
-   assert `(' conditionalExpression `)' `{\escapegrammar ;}'
+   assert `(' expression `)' `{\escapegrammar ;}'
       .
 \end{grammar}
 
 \LMHash{}
 The assert statement has no effect in production mode. In checked mode, execution of an assert statement \code{\ASSERT{}($e$);} proceeds as follows:
 
 \LMHash{}
-The conditional expression $e$ is evaluated to an object $o$. If the class of $o$ is a subtype of \code{Function} then let $r$ be the result of invoking $o$ with no arguments. Otherwise, let $r$ be $o$.
+The expression $e$ is evaluated to an object $o$. If the class of $o$ is a subtype of \code{Function} then let $r$ be the result of invoking $o$ with no arguments. Otherwise, let $r$ be $o$.
 It is a dynamic type error if $o$ is not of type \code{bool} or of type \code{Function}, or if $r$ is not of type \code{bool}.  If $r$ is \FALSE{}, we say that the assertion failed. If $r$ is \TRUE{}, we say that the assertion succeeded. If the assertion succeeded, execution of the assert statement is complete. If the assertion failed, an \code{AssertionError} is thrown.
 
 %\Q{Might be cleaner to define it as \code{if (!$e$) \{\THROW{} \NEW{} AssertionError();\}} (in checked mode only).

pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart

@@ -71,31 +71,7 @@ abstract class LocalDeclarationVisitor extends GeneralizingAstVisitor {
 
   @override
   void visitBlock(Block node) {
-    for (Statement stmt in node.statements) {
-      if (stmt.offset < offset) {
-        if (stmt is VariableDeclarationStatement) {
-          VariableDeclarationList varList = stmt.variables;
-          if (varList != null) {
-            for (VariableDeclaration varDecl in varList.variables) {
-              if (varDecl.end < offset) {
-                declaredLocalVar(varDecl.name, varList.type);
-              }
-            }
-          }
-        } else if (stmt is FunctionDeclarationStatement) {
-          FunctionDeclaration declaration = stmt.functionDeclaration;
-          if (declaration != null && declaration.offset < offset) {
-            SimpleIdentifier id = declaration.name;
-            if (id != null) {
-              String name = id.name;
-              if (name != null && name.length > 0) {
-                declaredFunction(declaration);
-              }
-            }
-          }
-        }
-      }
-    }
+    _visitStatements(node.statements);
     visitNode(node);
   }
 
@@ -219,6 +195,12 @@ abstract class LocalDeclarationVisitor extends GeneralizingAstVisitor {
     visitNode(node);
   }
 
+  @override
+  void visitSwitchMember(SwitchMember node) {
+    _visitStatements(node.statements);
+    visitNode(node);
+  }
+
   @override
   void visitSwitchStatement(SwitchStatement node) {
     for (SwitchMember member in node.members) {
@@ -263,6 +245,34 @@ abstract class LocalDeclarationVisitor extends GeneralizingAstVisitor {
       });
     }
   }
+
+  _visitStatements(NodeList<Statement> statements) {
+    for (Statement stmt in statements) {
+      if (stmt.offset < offset) {
+        if (stmt is VariableDeclarationStatement) {
+          VariableDeclarationList varList = stmt.variables;
+          if (varList != null) {
+            for (VariableDeclaration varDecl in varList.variables) {
+              if (varDecl.end < offset) {
+                declaredLocalVar(varDecl.name, varList.type);
+              }
+            }
+          }
+        } else if (stmt is FunctionDeclarationStatement) {
+          FunctionDeclaration declaration = stmt.functionDeclaration;
+          if (declaration != null && declaration.offset < offset) {
+            SimpleIdentifier id = declaration.name;
+            if (id != null) {
+              String name = id.name;
+              if (name != null && name.length > 0) {
+                declaredFunction(declaration);
+              }
+            }
+          }
+        }
+      }
+    }
+  }
 }
 
 /**