Skip to content

Commit e46fa1c

Browse files
committed
Revert "[VM] Ensure Top level class is finalized for loadedscripts in library"
This reverts commit 9f00d1b. Reason for revert: This change triggered some incorrect runtime typecheck failures in Fuchsia. Original change's description: > [VM] Ensure Top level class is finalized for loadedscripts in library > > The breakpoints sent from IDE will be checked with existing scripts. > Because the loadedscripts() doesn't contain the scripts info for part/part of. > Then the breakpoint will be considerred as a latent breakpoint and didn't get > resolved later. The solution is to finalize the toplevel class before loadedscripts() > uses Dictionary iterator. > > Bug: #35859 > Change-Id: I90b67ee9e9e6afe2556ca806cdd87eb5661304a8 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97402 > Reviewed-by: Alexander Markov <[email protected]> > Commit-Queue: Zichang Guo <[email protected]> [email protected],[email protected],[email protected] # Not skipping CQ checks because original CL landed > 1 day ago. Bug: #35859 Change-Id: Ib28c2257f94b8d7ee0a3607be4a92153b7229e54 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98360 Reviewed-by: Zach Anderson <[email protected]>
1 parent e0a2651 commit e46fa1c

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

runtime/vm/object.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10389,7 +10389,6 @@ RawArray* Library::LoadedScripts() const {
1038910389
Object& entry = Object::Handle();
1039010390
Class& cls = Class::Handle();
1039110391
Script& owner_script = Script::Handle();
10392-
EnsureTopLevelClassIsFinalized();
1039310392
DictionaryIterator it(*this);
1039410393
while (it.HasNext()) {
1039510394
entry = it.GetNext();

0 commit comments

Comments
 (0)