[cfe] Add RecordType, RecordLiteral, and associated nodes

TEST=Covered by upcoming language and co19 tests.

Change-Id: Ibe8ecfb7f854adce5646125f6909066e27424665
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256066
Reviewed-by: Johnni Winther <[email protected]>
Reviewed-by: Stephen Adams <[email protected]>
Reviewed-by: Nicholas Shahan <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>
Reviewed-by: Alexander Markov <[email protected]>

Author: chloestefantsova

pkg/compiler/lib/src/inferrer/builder.dart

@@ -725,6 +725,11 @@ class KernelTypeGraphBuilder extends ir.Visitor<TypeInformation>
     });
   }
 
+  @override
+  TypeInformation visitRecordLiteral(ir.RecordLiteral node) {
+    return defaultExpression(node);
+  }
+
   @override
   TypeInformation visitReturnStatement(ir.ReturnStatement node) {
     ir.Node expression = node.expression;
@@ -2322,6 +2327,11 @@ class TypeInformationConstantVisitor
         isConst: true);
   }
 
+  @override
+  TypeInformation visitRecordConstant(ir.RecordConstant node) {
+    return defaultConstant(node);
+  }
+
   @override
   TypeInformation visitInstanceConstant(ir.InstanceConstant node) {
     node.fieldValues.forEach((ir.Reference reference, ir.Constant value) {

pkg/compiler/lib/src/ir/impact.dart

@@ -300,6 +300,11 @@ class ConstantImpactVisitor extends ir.VisitOnceConstantVisitor {
     }
   }
 
+  @override
+  void visitRecordConstant(ir.RecordConstant node) {
+    return defaultConstant(node);
+  }
+
   @override
   void visitSymbolConstant(ir.SymbolConstant node) {
     // TODO(johnniwinther): Handle the library reference.

pkg/compiler/lib/src/ir/util.dart

@@ -209,6 +209,15 @@ class _FreeVariableVisitor implements ir.DartTypeVisitor<bool> {
     return false;
   }
 
+  @override
+  bool visitRecordType(ir.RecordType node) {
+    if (visitList(node.positional)) return true;
+    for (ir.NamedType namedType in node.named) {
+      if (visit(namedType.type)) return true;
+    }
+    return false;
+  }
+
   @override
   bool visitInterfaceType(ir.InterfaceType node) {
     return visitList(node.typeArguments);

pkg/compiler/lib/src/ir/visitors.dart

@@ -296,6 +296,11 @@ class ConstantValuefier extends ir.ComputeOnceConstantVisitor<ConstantValue> {
         elementMap.commonElements, type, keys, values);
   }
 
+  @override
+  ConstantValue visitRecordConstant(ir.RecordConstant node) {
+    return defaultConstant(node);
+  }
+
   @override
   ConstantValue visitSymbolConstant(ir.SymbolConstant node) {
     return constant_system.createSymbol(elementMap.commonElements, node.name);

pkg/compiler/lib/src/serialization/node_indexer.dart

@@ -354,6 +354,18 @@ class ConstantNodeIndexerVisitor implements ir.ConstantVisitor<void> {
     }
   }
 
+  @override
+  void visitRecordConstant(ir.RecordConstant node) {
+    if (_register(node)) {
+      for (ir.Constant field in node.positional) {
+        field.accept(this);
+      }
+      for (ir.ConstantRecordNamedField namedField in node.named) {
+        namedField.value.accept(this);
+      }
+    }
+  }
+
   @override
   void visitSymbolConstant(ir.SymbolConstant node) {
     _register(node);

pkg/compiler/test/helpers/ir_types.dart

@@ -96,6 +96,27 @@ class TypeTextVisitor implements ir.DartTypeVisitor1<void, StringBuffer> {
     sb.write(')');
   }
 
+  @override
+  void visitRecordType(ir.RecordType node, StringBuffer sb) {
+    sb.write('Record');
+    sb.write('(');
+    _writeTypes(node.positional, sb);
+    if (node.named.isNotEmpty) {
+      if (node.positional.isNotEmpty) {
+        sb.write(',');
+      }
+      String comma = '';
+      for (ir.NamedType namedType in node.named) {
+        sb.write(comma);
+        sb.write(namedType.name);
+        sb.write(': ');
+        writeType(namedType.type, sb);
+        comma = ',';
+      }
+    }
+    sb.write(')');
+  }
+
   @override
   void visitInterfaceType(ir.InterfaceType node, StringBuffer sb) {
     sb.write(node.classNode.name);

pkg/dev_compiler/lib/src/kernel/compiler.dart

@@ -3188,6 +3188,9 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
         : typeRep;
   }
 
+  @override
+  js_ast.Expression visitRecordType(type) => defaultDartType(type);
+
   /// Emits an expression that lets you access statics on a [type] from code.
   js_ast.Expression _emitConstructorAccess(InterfaceType type) {
     return _emitJSInterop(type.classNode) ??
@@ -4637,6 +4640,16 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
         node.receiver, node.interfaceTarget, node.name.text);
   }
 
+  @override
+  js_ast.Expression visitRecordIndexGet(RecordIndexGet node) {
+    return defaultExpression(node);
+  }
+
+  @override
+  js_ast.Expression visitRecordNameGet(RecordNameGet node) {
+    return defaultExpression(node);
+  }
+
   @override
   js_ast.Expression visitInstanceTearOff(InstanceTearOff node) {
     return _emitPropertyGet(
@@ -6315,6 +6328,10 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
         [_emitType(keyType), _emitType(valueType), entries]));
   }
 
+  @override
+  js_ast.Expression visitRecordLiteral(RecordLiteral node) =>
+      defaultExpression(node);
+
   @override
   js_ast.Expression visitAwaitExpression(AwaitExpression node) =>
       js_ast.Yield(_visitExpression(node.operand));
@@ -6645,6 +6662,10 @@ class ProgramCompiler extends ComputeOnceConstantVisitor<js_ast.Expression>
   js_ast.Expression visitSetConstant(SetConstant node) => _emitConstSet(
       node.typeArgument, node.entries.map(visitConstant).toList());
 
+  @override
+  js_ast.Expression visitRecordConstant(RecordConstant node) =>
+      defaultConstant(node);
+
   @override
   js_ast.Expression visitInstanceConstant(InstanceConstant node) {
     _declareBeforeUse(node.classNode);

pkg/front_end/lib/src/fasta/fasta_codes_cfe_generated.dart

@@ -657,6 +657,82 @@ Message _withArgumentsConstEvalInvalidPropertyGet(
       arguments: {'stringOKEmpty': stringOKEmpty, 'constant': _constant});
 }
 
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Template<
+        Message Function(String stringOKEmpty, Constant _constant,
+            bool isNonNullableByDefault)>
+    templateConstEvalInvalidRecordIndexGet = const Template<
+            Message Function(
+                String stringOKEmpty,
+                Constant _constant,
+                bool
+                    isNonNullableByDefault)>(
+        problemMessageTemplate:
+            r"""The property '#stringOKEmpty' can't be accessed on '#constant' in a constant expression.""",
+        withArguments: _withArgumentsConstEvalInvalidRecordIndexGet);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<
+        Message Function(String stringOKEmpty, Constant _constant,
+            bool isNonNullableByDefault)> codeConstEvalInvalidRecordIndexGet =
+    const Code<
+            Message Function(String stringOKEmpty, Constant _constant,
+                bool isNonNullableByDefault)>("ConstEvalInvalidRecordIndexGet",
+        analyzerCodes: <String>["CONST_EVAL_THROWS_EXCEPTION"]);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+Message _withArgumentsConstEvalInvalidRecordIndexGet(
+    String stringOKEmpty, Constant _constant, bool isNonNullableByDefault) {
+  // ignore: unnecessary_null_comparison
+  if (stringOKEmpty == null || stringOKEmpty.isEmpty) stringOKEmpty = '(empty)';
+  TypeLabeler labeler = new TypeLabeler(isNonNullableByDefault);
+  List<Object> constantParts = labeler.labelConstant(_constant);
+  String constant = constantParts.join();
+  return new Message(codeConstEvalInvalidRecordIndexGet,
+      problemMessage:
+          """The property '${stringOKEmpty}' can't be accessed on '${constant}' in a constant expression.""" +
+              labeler.originMessages,
+      arguments: {'stringOKEmpty': stringOKEmpty, 'constant': _constant});
+}
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Template<
+        Message Function(String stringOKEmpty, Constant _constant,
+            bool isNonNullableByDefault)>
+    templateConstEvalInvalidRecordNameGet = const Template<
+            Message Function(
+                String stringOKEmpty,
+                Constant _constant,
+                bool
+                    isNonNullableByDefault)>(
+        problemMessageTemplate:
+            r"""The property '#stringOKEmpty' can't be accessed on '#constant' in a constant expression.""",
+        withArguments: _withArgumentsConstEvalInvalidRecordNameGet);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<
+        Message Function(String stringOKEmpty, Constant _constant,
+            bool isNonNullableByDefault)> codeConstEvalInvalidRecordNameGet =
+    const Code<
+            Message Function(String stringOKEmpty, Constant _constant,
+                bool isNonNullableByDefault)>("ConstEvalInvalidRecordNameGet",
+        analyzerCodes: <String>["CONST_EVAL_THROWS_EXCEPTION"]);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+Message _withArgumentsConstEvalInvalidRecordNameGet(
+    String stringOKEmpty, Constant _constant, bool isNonNullableByDefault) {
+  // ignore: unnecessary_null_comparison
+  if (stringOKEmpty == null || stringOKEmpty.isEmpty) stringOKEmpty = '(empty)';
+  TypeLabeler labeler = new TypeLabeler(isNonNullableByDefault);
+  List<Object> constantParts = labeler.labelConstant(_constant);
+  String constant = constantParts.join();
+  return new Message(codeConstEvalInvalidRecordNameGet,
+      problemMessage:
+          """The property '${stringOKEmpty}' can't be accessed on '${constant}' in a constant expression.""" +
+              labeler.originMessages,
+      arguments: {'stringOKEmpty': stringOKEmpty, 'constant': _constant});
+}
+
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Template<
         Message Function(Constant _constant, bool isNonNullableByDefault)>
@@ -1843,6 +1919,45 @@ Message _withArgumentsIncorrectTypeArgumentQualifiedInferred(
       });
 }
 
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Template<
+        Message Function(int count, int count2, DartType _type,
+            bool isNonNullableByDefault)>
+    templateIndexOutOfBoundInRecordIndexGet =
+    const Template<
+            Message Function(int count, int count2, DartType _type,
+                bool isNonNullableByDefault)>(
+        problemMessageTemplate:
+            r"""Index #count is out of range 0..#count2 of positional fields of records #type.""",
+        withArguments: _withArgumentsIndexOutOfBoundInRecordIndexGet);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<
+        Message Function(
+            int count, int count2, DartType _type, bool isNonNullableByDefault)>
+    codeIndexOutOfBoundInRecordIndexGet = const Code<
+        Message Function(int count, int count2, DartType _type,
+            bool isNonNullableByDefault)>(
+  "IndexOutOfBoundInRecordIndexGet",
+);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+Message _withArgumentsIndexOutOfBoundInRecordIndexGet(
+    int count, int count2, DartType _type, bool isNonNullableByDefault) {
+  // ignore: unnecessary_null_comparison
+  if (count == null) throw 'No count provided';
+  // ignore: unnecessary_null_comparison
+  if (count2 == null) throw 'No count provided';
+  TypeLabeler labeler = new TypeLabeler(isNonNullableByDefault);
+  List<Object> typeParts = labeler.labelType(_type);
+  String type = typeParts.join();
+  return new Message(codeIndexOutOfBoundInRecordIndexGet,
+      problemMessage:
+          """Index ${count} is out of range 0..${count2} of positional fields of records ${type}.""" +
+              labeler.originMessages,
+      arguments: {'count': count, 'count2': count2, 'type': _type});
+}
+
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Template<
         Message Function(
@@ -3690,6 +3805,41 @@ Message _withArgumentsMixinInferenceNoMatchingClass(
       arguments: {'name': name, 'name2': name2, 'type': _type});
 }
 
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Template<
+        Message Function(
+            String string, DartType _type, bool isNonNullableByDefault)>
+    templateNameNotFoundInRecordNameGet = const Template<
+            Message Function(
+                String string, DartType _type, bool isNonNullableByDefault)>(
+        problemMessageTemplate:
+            r"""Field name #string isn't found in records of type #type.""",
+        withArguments: _withArgumentsNameNotFoundInRecordNameGet);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+const Code<
+        Message Function(
+            String string, DartType _type, bool isNonNullableByDefault)>
+    codeNameNotFoundInRecordNameGet = const Code<
+        Message Function(
+            String string, DartType _type, bool isNonNullableByDefault)>(
+  "NameNotFoundInRecordNameGet",
+);
+
+// DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
+Message _withArgumentsNameNotFoundInRecordNameGet(
+    String string, DartType _type, bool isNonNullableByDefault) {
+  if (string.isEmpty) throw 'No string provided';
+  TypeLabeler labeler = new TypeLabeler(isNonNullableByDefault);
+  List<Object> typeParts = labeler.labelType(_type);
+  String type = typeParts.join();
+  return new Message(codeNameNotFoundInRecordNameGet,
+      problemMessage:
+          """Field name ${string} isn't found in records of type ${type}.""" +
+              labeler.originMessages,
+      arguments: {'string': string, 'type': _type});
+}
+
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Template<Message Function(DartType _type, bool isNonNullableByDefault)>
     templateNonNullAwareSpreadIsNull = const Template<