Skip to content

Commit d9363a6

Browse files
DanTupCommit Queue
authored and
Commit Queue
committed
[analysis_server] Don't show expression snippets in argument names
Fixes Dart-Code/Dart-Code#4635 Change-Id: I8e8addabc7bd601ad9a9abffb87f318243255932 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316222 Reviewed-by: Brian Wilkerson <[email protected]> Commit-Queue: Brian Wilkerson <[email protected]>
1 parent abc712a commit d9363a6

File tree

3 files changed

+13
-0
lines changed

3 files changed

+13
-0
lines changed

pkg/analysis_server/lib/src/services/snippets/dart_snippet_request.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,10 @@ class DartSnippetRequest {
6060
tokenType == TokenType.STRING_INTERPOLATION_IDENTIFIER) {
6161
return SnippetContext.inString;
6262
}
63+
} else if (entity is NamedExpression &&
64+
target.offset >= entity.name.offset &&
65+
target.offset <= entity.name.end) {
66+
return SnippetContext.inName;
6367
}
6468

6569
AstNode? node = target.containingNode;

pkg/analysis_server/lib/src/services/snippets/snippet_context.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,4 +20,5 @@ enum SnippetContext {
2020
inQualifiedMemberAccess,
2121
inStatement,
2222
inString,
23+
inName,
2324
}

pkg/analysis_server/test/services/snippets/snippet_request_test.dart

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,14 @@ class A {}
3232
''', SnippetContext.inAnnotation);
3333
}
3434

35+
Future<void> test_argumentName() async {
36+
await testRequest(r'''
37+
void({required int switch}) {
38+
f([!sw^!]:);
39+
}
40+
''', SnippetContext.inName);
41+
}
42+
3543
Future<void> test_block_forBody() async {
3644
await testRequest(r'''
3745
foo() {

0 commit comments

Comments
 (0)