Temporarily disable 'Allow the incremental compiler to load modules'

jensjoha · jensjoha · commit cf768254fd2d · 2019-03-28T09:59:29.000Z
Caused weird test failures. Disabling while investigating. Change-Id: I566a209175a1ad6a4384ee815f54ba04bdb75570 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98120 Reviewed-by: Jens Johansen <jensj@google.com>
diff --git a/pkg/front_end/lib/src/fasta/incremental_compiler.dart b/pkg/front_end/lib/src/fasta/incremental_compiler.dart
@@ -227,7 +227,7 @@ class IncrementalCompiler implements IncrementalKernelGenerator {
         CompilerContext.current.uriToSource.remove(builder.fileUri);
       }
 
-      if (hasToCheckPackageUris) {
+      if (hasToCheckPackageUris && false) {
         // The package file was changed.
         // Make sure the dill loader is on the same page.
         DillTarget oldDillLoadedData = dillLoadedData;
diff --git a/pkg/front_end/testcases/incremental_initialize_from_dill/status.status b/pkg/front_end/testcases/incremental_initialize_from_dill/status.status
@@ -3,3 +3,4 @@
 # BSD-style license that can be found in the LICENSE.md file.
 
 # Status file for the test suite ../test/incremental_load_from_dill_yaml_test.dart.
+changing_modules: Crash

Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,7 @@ class IncrementalCompiler implements IncrementalKernelGenerator {`
`227`	`227`	`CompilerContext.current.uriToSource.remove(builder.fileUri);`
`228`	`228`	`}`
`229`	`229`
`230`		`- if (hasToCheckPackageUris) {`
	`230`	`+ if (hasToCheckPackageUris && false) {`
`231`	`231`	`// The package file was changed.`
`232`	`232`	`// Make sure the dill loader is on the same page.`
`233`	`233`	`DillTarget oldDillLoadedData = dillLoadedData;`
Original file line number	Diff line number	Diff line change
`@@ -3,3 +3,4 @@`
`3`	`3`	`# BSD-style license that can be found in the LICENSE.md file.`
`4`	`4`
`5`	`5`	`# Status file for the test suite ../test/incremental_load_from_dill_yaml_test.dart.`
	`6`	`+changing_modules: Crash`