Skip to content

Commit ceace12

Browse files
rakudramacommit-bot@chromium.org
authored andcommitted
dart2js: Work-around for imprecise calledOnce info
Change-Id: Id1118a394a2be5c8a1844ce40ce33512239bf650 Reviewed-on: https://dart-review.googlesource.com/70843 Reviewed-by: Johnni Winther <[email protected]> Commit-Queue: Stephen Adams <[email protected]>
1 parent d10204f commit ceace12

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

pkg/compiler/lib/src/ssa/builder_kernel.dart

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5066,12 +5066,17 @@ class KernelSsaGraphBuilder extends ir.Visitor
50665066
_elementMap, function, maxInliningNodes,
50675067
allowLoops: allowLoops,
50685068
enableUserAssertions: options.enableUserAssertions);
5069-
if (markedTryInline || calledOnce) {
5069+
if (markedTryInline) {
50705070
if (canInline) {
5071+
inlineCache.markAsInlinable(function, insideLoop: true);
50715072
inlineCache.markAsInlinable(function, insideLoop: false);
50725073
} else {
50735074
inlineCache.markAsNonInlinable(function, insideLoop: true);
5075+
inlineCache.markAsNonInlinable(function, insideLoop: false);
50745076
}
5077+
} else if (calledOnce) {
5078+
// TODO(34203): We can't update the decision due to imprecision in the
5079+
// calledOnce data, described in Issue 34203.
50755080
} else {
50765081
if (canInline) {
50775082
inlineCache.markAsInlinable(function, insideLoop: insideLoop);

0 commit comments

Comments
 (0)