Skip to content

Commit cc9d14d

Browse files
sstricklCommit Bot
authored and
Commit Bot
committed
[vm] Remove warnings about non-standard stack traces.
The language team has clarified in dart-lang/language#1212 that the content of stack traces is not specified in a way that is violated by either obfuscation or non-symbolic stack traces. Thus, we remove the warnings about supposedly standard-violating stack traces. TEST=No change in actual functionality, so tested manually. Bug: #43388 Change-Id: I2c7ac44cf2f9afafa85d902b2783e1173e727264 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249185 Commit-Queue: Tess Strickland <[email protected]> Reviewed-by: Daco Harkes <[email protected]> Reviewed-by: Martin Kustermann <[email protected]>
1 parent 707ade9 commit cc9d14d

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

runtime/vm/isolate.cc

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1739,13 +1739,6 @@ Isolate::Isolate(IsolateGroup* isolate_group,
17391739
// how the vm_tag (kEmbedderTagId) can be set, these tags need to
17401740
// move to the OSThread structure.
17411741
set_user_tag(UserTags::kDefaultUserTag);
1742-
1743-
if (group()->obfuscate()) {
1744-
OS::PrintErr(
1745-
"Warning: This VM has been configured to obfuscate symbol information "
1746-
"which violates the Dart standard.\n"
1747-
" See dartbug.com/30524 for more information.\n");
1748-
}
17491742
}
17501743

17511744
#undef REUSABLE_HANDLE_SCOPE_INIT

runtime/vm/object.cc

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25878,12 +25878,6 @@ const char* StackTrace::ToCString() const {
2587825878
isolate_instructions_image.instructions_relocated_address();
2587925879
auto const vm_relocated_address =
2588025880
vm_instructions_image.instructions_relocated_address();
25881-
// The Dart standard requires the output of StackTrace.toString to include
25882-
// all pending activations with precise source locations (i.e., to expand
25883-
// inlined frames and provide line and column numbers).
25884-
buffer.Printf(
25885-
"Warning: This VM has been configured to produce stack traces "
25886-
"that violate the Dart standard.\n");
2588725881
// This prologue imitates Android's debuggerd to make it possible to paste
2588825882
// the stack trace into ndk-stack.
2588925883
buffer.Printf(

0 commit comments

Comments
 (0)