Skip to content

Commit c723dae

Browse files
bwilkersoncommit-bot@chromium.org
authored andcommitted
Add missed tests for noSuchMethod relevance
Also renamed other tests in this directory to not duplicate the directory name. Change-Id: I8aec73c6e44ca05f385f21b32f9c5feef1df67ef Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/183121 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Brian Wilkerson <[email protected]>
1 parent 222b894 commit c723dae

9 files changed

+87
-29
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ import 'completion_relevance.dart';
99

1010
void main() {
1111
defineReflectiveSuite(() {
12-
defineReflectiveTests(BoolAssignmentRelevanceTest);
12+
defineReflectiveTests(BoolAssignmentTest);
1313
});
1414
}
1515

1616
@reflectiveTest
17-
class BoolAssignmentRelevanceTest extends CompletionRelevanceTest {
17+
class BoolAssignmentTest extends CompletionRelevanceTest {
1818
Future<void> test_boolLiterals_imported() async {
1919
await addTestFile('''
2020
foo() {
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ import 'completion_relevance.dart';
99

1010
void main() {
1111
defineReflectiveSuite(() {
12-
defineReflectiveTests(DeprecatedMemberRelevanceTest);
12+
defineReflectiveTests(DeprecatedMemberTest);
1313
});
1414
}
1515

1616
@reflectiveTest
17-
class DeprecatedMemberRelevanceTest extends CompletionRelevanceTest {
17+
class DeprecatedMemberTest extends CompletionRelevanceTest {
1818
Future<void> test_deprecated() async {
1919
await addTestFile('''
2020
class A {
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ import 'completion_relevance.dart';
88

99
void main() {
1010
defineReflectiveSuite(() {
11-
defineReflectiveTests(InstanceMemberRelevanceTest);
11+
defineReflectiveTests(InstanceMemberTest);
1212
});
1313
}
1414

1515
@reflectiveTest
16-
class InstanceMemberRelevanceTest extends CompletionRelevanceTest {
16+
class InstanceMemberTest extends CompletionRelevanceTest {
1717
@override
1818
bool get supportsAvailableSuggestions => true;
1919

Lines changed: 57 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,57 @@
1+
// Copyright (c) 2021, the Dart project authors. Please see the AUTHORS file
2+
// for details. All rights reserved. Use of this source code is governed by a
3+
// BSD-style license that can be found in the LICENSE file.
4+
5+
import 'package:analyzer_plugin/protocol/protocol_common.dart';
6+
import 'package:test_reflective_loader/test_reflective_loader.dart';
7+
8+
import 'completion_relevance.dart';
9+
10+
void main() {
11+
defineReflectiveSuite(() {
12+
defineReflectiveTests(IsNoSuchMethodTest);
13+
});
14+
}
15+
16+
@reflectiveTest
17+
class IsNoSuchMethodTest extends CompletionRelevanceTest {
18+
Future<void> test_notSuper() async {
19+
await addTestFile('''
20+
void foo(Object o) {
21+
o.^;
22+
}
23+
''');
24+
25+
var toStringSuggestion = suggestionWith(
26+
completion: 'toString',
27+
element: ElementKind.METHOD,
28+
kind: CompletionSuggestionKind.INVOCATION);
29+
30+
var noSuchMethodSuggestion = suggestionWith(
31+
completion: 'noSuchMethod',
32+
element: ElementKind.METHOD,
33+
kind: CompletionSuggestionKind.INVOCATION);
34+
35+
assertOrder([toStringSuggestion, noSuchMethodSuggestion]);
36+
}
37+
38+
Future<void> test_super() async {
39+
await addTestFile('''
40+
class C {
41+
dynamic noSuchMethod(Invocation i) => super.^;
42+
}
43+
''');
44+
45+
var toStringSuggestion = suggestionWith(
46+
completion: 'toString',
47+
element: ElementKind.METHOD,
48+
kind: CompletionSuggestionKind.INVOCATION);
49+
50+
var noSuchMethodSuggestion = suggestionWith(
51+
completion: 'noSuchMethod',
52+
element: ElementKind.METHOD,
53+
kind: CompletionSuggestionKind.INVOCATION);
54+
55+
assertOrder([noSuchMethodSuggestion, toStringSuggestion]);
56+
}
57+
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ import 'completion_relevance.dart';
99

1010
void main() {
1111
defineReflectiveSuite(() {
12-
defineReflectiveTests(LocalVariableRelevanceTest);
12+
defineReflectiveTests(LocalVariableTest);
1313
});
1414
}
1515

1616
@reflectiveTest
17-
class LocalVariableRelevanceTest extends CompletionRelevanceTest {
17+
class LocalVariableTest extends CompletionRelevanceTest {
1818
Future<void> test_localVariables() async {
1919
await addTestFile('''
2020
int f() {
Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,13 @@ import 'completion_relevance.dart';
99

1010
void main() {
1111
defineReflectiveSuite(() {
12-
defineReflectiveTests(NamedArgumentRelevanceTest);
13-
defineReflectiveTests(NamedArgumentRelevanceWithNullSafetyTest);
12+
defineReflectiveTests(NamedArgumentTest);
13+
defineReflectiveTests(NamedArgumentWithNullSafetyTest);
1414
});
1515
}
1616

1717
@reflectiveTest
18-
class NamedArgumentRelevanceTest extends CompletionRelevanceTest {
18+
class NamedArgumentTest extends CompletionRelevanceTest {
1919
@override
2020
void setUp() {
2121
super.setUp();
@@ -44,8 +44,7 @@ void g() => f(^);
4444
}
4545

4646
@reflectiveTest
47-
class NamedArgumentRelevanceWithNullSafetyTest
48-
extends NamedArgumentRelevanceTest {
47+
class NamedArgumentWithNullSafetyTest extends NamedArgumentTest {
4948
Future<void> test_required() async {
5049
await addTestFile('''
5150
void f({int a = 0, required int b}) {}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ import 'completion_relevance.dart';
99

1010
void main() {
1111
defineReflectiveSuite(() {
12-
defineReflectiveTests(NonTypeMemberRelevanceTest);
12+
defineReflectiveTests(NonTypeMemberTest);
1313
});
1414
}
1515

1616
@reflectiveTest
17-
class NonTypeMemberRelevanceTest extends CompletionRelevanceTest {
17+
class NonTypeMemberTest extends CompletionRelevanceTest {
1818
Future<void> test_contextType_constructorInvocation_before_type() async {
1919
await addTestFile('''
2020
class StrWrap {
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ import 'completion_relevance.dart';
88

99
void main() {
1010
defineReflectiveSuite(() {
11-
defineReflectiveTests(StaticMemberRelevanceTest);
11+
defineReflectiveTests(StaticMemberTest);
1212
});
1313
}
1414

1515
@reflectiveTest
16-
class StaticMemberRelevanceTest extends CompletionRelevanceTest {
16+
class StaticMemberTest extends CompletionRelevanceTest {
1717
Future<void> test_contextType() async {
1818
await addTestFile(r'''
1919
class A {}

pkg/analysis_server/test/services/completion/dart/relevance/test_all.dart

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,22 +4,24 @@
44

55
import 'package:test_reflective_loader/test_reflective_loader.dart';
66

7-
import 'bool_assignment_relevance_test.dart' as bool_assignments;
8-
import 'deprecated_member_relevance_test.dart' as deprecated_members;
9-
import 'instance_member_relevance_test.dart' as instance_member_relevance;
10-
import 'local_variable_relevance_test.dart' as local_variable_relevance;
11-
import 'named_argument_relevance_test.dart' as named_argument_relevance;
12-
import 'non_type_member_relevance_test.dart' as non_type_member_relevance;
13-
import 'static_member_relevance_test.dart' as static_member_relevance;
7+
import 'bool_assignment_test.dart' as bool_assignments;
8+
import 'deprecated_member_test.dart' as deprecated_members;
9+
import 'instance_member_test.dart' as instance_member;
10+
import 'is_no_such_method_test.dart' as is_no_such_method;
11+
import 'local_variable_test.dart' as local_variable;
12+
import 'named_argument_test.dart' as named_argument;
13+
import 'non_type_member_test.dart' as non_type_member;
14+
import 'static_member_test.dart' as static_member;
1415

1516
void main() {
1617
defineReflectiveSuite(() {
1718
bool_assignments.main();
1819
deprecated_members.main();
19-
instance_member_relevance.main();
20-
local_variable_relevance.main();
21-
named_argument_relevance.main();
22-
non_type_member_relevance.main();
23-
static_member_relevance.main();
20+
instance_member.main();
21+
is_no_such_method.main();
22+
local_variable.main();
23+
named_argument.main();
24+
non_type_member.main();
25+
static_member.main();
2426
});
2527
}

0 commit comments

Comments
 (0)