[analyzer] Replace non-serializable nodes in asserts.

Function expressions and other non-serializable nodes are crashing the asserts in const constructors because they are not being replaced with a marker.

Fixes #53075

Bug: #53075
Change-Id: I366e7cbd2853c57aaee358caa93f197e241fbf1b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/329240
Reviewed-by: Nate Bosch <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

pkg/analyzer/lib/src/summary2/detach_nodes.dart

@@ -34,14 +34,23 @@ class _Visitor extends GeneralizingElementVisitor<void> {
       initializers.forEach(_detachNode);
 
       for (final initializer in initializers) {
-        if (initializer is ConstructorFieldInitializerImpl) {
-          final expression = initializer.expression;
-          final replacement = replaceNotSerializableNode(expression);
-          initializer.expression = replacement;
-        } else if (initializer is RedirectingConstructorInvocationImpl) {
-          _sanitizeArguments(initializer.argumentList.arguments);
-        } else if (initializer is SuperConstructorInvocationImpl) {
-          _sanitizeArguments(initializer.argumentList.arguments);
+        if (initializer is! ConstructorInitializerImpl) continue;
+        switch (initializer) {
+          case AssertInitializerImpl(:final condition, :final message):
+            var conditionReplacement = replaceNotSerializableNode(condition);
+            initializer.condition = conditionReplacement;
+
+            if (message != null) {
+              var messageReplacement = replaceNotSerializableNode(message);
+              initializer.message = messageReplacement;
+            }
+          case ConstructorFieldInitializerImpl(:final expression):
+            var replacement = replaceNotSerializableNode(expression);
+            initializer.expression = replacement;
+          case RedirectingConstructorInvocationImpl(:final argumentList):
+            _sanitizeArguments(argumentList.arguments);
+          case SuperConstructorInvocationImpl(:final argumentList):
+            _sanitizeArguments(argumentList.arguments);
         }
       }
 

pkg/analyzer/test/src/summary/elements_test.dart

@@ -16635,6 +16635,61 @@ library
 ''');
   }
 
+  test_const_invalid_functionExpression_assertInitializer() async {
+    var library = await buildLibrary('''
+class A  {
+  const A() : assert((() => true)());
+}
+''');
+    checkElementText(library, r'''
+library
+  definingUnit
+    classes
+      class A @6
+        constructors
+          const @19
+            constantInitializers
+              AssertInitializer
+                assertKeyword: assert @25
+                leftParenthesis: ( @31
+                condition: SimpleIdentifier
+                  token: _notSerializableExpression @-1
+                  staticElement: <null>
+                  staticType: null
+                rightParenthesis: ) @46
+''');
+  }
+
+  test_const_invalid_functionExpression_assertInitializer_message() async {
+    var library = await buildLibrary('''
+class A  {
+  const A() : assert(b, () => 0);
+}
+''');
+    checkElementText(library, r'''
+library
+  definingUnit
+    classes
+      class A @6
+        constructors
+          const @19
+            constantInitializers
+              AssertInitializer
+                assertKeyword: assert @25
+                leftParenthesis: ( @31
+                condition: SimpleIdentifier
+                  token: b @32
+                  staticElement: <null>
+                  staticType: InvalidType
+                comma: , @33
+                message: SimpleIdentifier
+                  token: _notSerializableExpression @-1
+                  staticElement: <null>
+                  staticType: null
+                rightParenthesis: ) @42
+''');
+  }
+
   test_const_invalid_functionExpression_constructorFieldInitializer() async {
     var library = await buildLibrary('''
 class A {