Skip to content

Commit b6207eb

Browse files
dcharkesCommit Queue
authored and
Commit Queue
committed
[deps] Roll dart-lang/native
Adds the missing argument to `link`. Change-Id: I8a9d167b046ac301e5274a5062e30d6c186ac257 Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-arm64-try,pkg-linux-release-try,pkg-mac-release-arm64-try,pkg-mac-release-try,pkg-win-release-arm64-try,pkg-win-release-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/366381 Reviewed-by: Hossein Yousefi <[email protected]> Commit-Queue: Hossein Yousefi <[email protected]> Auto-Submit: Daco Harkes <[email protected]> Commit-Queue: Daco Harkes <[email protected]>
1 parent 73bdc86 commit b6207eb

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ vars = {
164164
"material_color_utilities_rev": "799b6ba2f3f1c28c67cc7e0b4f18e0c7d7f3c03e",
165165
"mime_rev": "b01c9a24e0991da479bd405138be3b3e403ff456",
166166
"mockito_rev": "4be52e16d06c8c5384d1cf5a511f0c9a7d829cf7",
167-
"native_rev": "7bca3567228c259dd5cc8e8530cd1585d8de42a0", # mosum@ and dacoharkes@ are rolling breaking changes manually while the assets features are in experimental.
167+
"native_rev": "fef40aebc3cf34654919e8a5785b6c50b3ea445c", # mosum@ and dacoharkes@ are rolling breaking changes manually while the assets features are in experimental.
168168
"package_config_rev": "39096768806ccae4b7025dd4114f15f2df424b0c",
169169
"path_rev": "9be79e72be7837fd8b99ae51a69f4c9f04ec29b4",
170170
"pool_rev": "1a6f2df19d7a24baaf674e032a0310a4f76725de",

pkg/dartdev/lib/src/commands/build.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,7 @@ class BuildCommand extends DartdevCommand {
175175
resourceIdentifiers: Uri.file(resources),
176176
workingDirectory: workingDirectory,
177177
target: target,
178+
linkModePreference: LinkModePreferenceImpl.dynamic,
178179
buildMode: BuildModeImpl.release,
179180
includeParentEnvironment: true,
180181
buildResult: buildResult,

pkg/dartdev/lib/src/native_assets.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,11 @@ Future<(bool success, List<AssetImpl> assets)> compileNativeAssetsJit({
5252

5353
final linkResult = await nativeAssetsBuildRunner.link(
5454
workingDirectory: workingDirectory,
55+
// When running in JIT mode, only the host OS needs to be build.
5556
target: Target.current,
57+
// When running in JIT mode, only dynamic libraries are supported.
58+
linkModePreference: LinkModePreferenceImpl.dynamic,
59+
// Dart has no concept of release vs debug, default to release.
5660
buildMode: BuildModeImpl.release,
5761
includeParentEnvironment: true,
5862
buildResult: buildResult,

0 commit comments

Comments
 (0)