[wildcards] remove wildcard opinions from non_constant_identifier_names

TL;DR this returns the lint to a pre-wildcard feature laissez faire attitude towards underscores.

There's ongoing conversation about how we want to nudge folks to avoid needless use of underscores on #56595 but it's not likely to happen in this lint (and almost certainly not before the feature is enabled).

Change-Id: I9aff2bc225616336655cddbc2635b427265497bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381903
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: pq

pkg/linter/lib/src/rules/non_constant_identifier_names.dart

@@ -2,11 +2,9 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
-import 'package:analyzer/dart/element/element.dart';
 
 import '../analyzer.dart';
 import '../extensions.dart';
@@ -50,7 +48,7 @@ class NonConstantIdentifierNames extends LintRule {
   @override
   void registerNodeProcessors(
       NodeLintRegistry registry, LinterContext context) {
-    var visitor = _Visitor(this, context.libraryElement);
+    var visitor = _Visitor(this);
     registry.addCatchClause(this, visitor);
     registry.addConstructorDeclaration(this, visitor);
     registry.addDeclaredVariablePattern(this, visitor);
@@ -68,14 +66,9 @@ class NonConstantIdentifierNames extends LintRule {
 }
 
 class _Visitor extends SimpleAstVisitor<void> {
-  /// Whether the `wildcard_variables` feature is enabled.
-  final bool _wildCardVariablesEnabled;
-
   final LintRule rule;
 
-  _Visitor(this.rule, LibraryElement? library)
-      : _wildCardVariablesEnabled =
-            library?.featureSet.isEnabled(Feature.wildcard_variables) ?? false;
+  _Visitor(this.rule);
 
   void checkIdentifier(Token? id, {bool underscoresOk = false}) {
     if (id == null) {
@@ -93,10 +86,8 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   @override
   void visitCatchClause(CatchClause node) {
-    checkIdentifier(node.exceptionParameter?.name,
-        underscoresOk: !_wildCardVariablesEnabled);
-    checkIdentifier(node.stackTraceParameter?.name,
-        underscoresOk: !_wildCardVariablesEnabled);
+    checkIdentifier(node.exceptionParameter?.name, underscoresOk: true);
+    checkIdentifier(node.stackTraceParameter?.name, underscoresOk: true);
   }
 
   @override
@@ -129,7 +120,7 @@ class _Visitor extends SimpleAstVisitor<void> {
     for (var p in node.parameters) {
       if (inAugmentation && p.isNamed) continue;
       if (p is! FieldFormalParameter) {
-        checkIdentifier(p.name, underscoresOk: !_wildCardVariablesEnabled);
+        checkIdentifier(p.name, underscoresOk: true);
       }
     }
   }

pkg/linter/test/rules/non_constant_identifier_names_test.dart

@@ -392,6 +392,7 @@ augment int Xx = 2;
 ''');
   }
 
+  @FailingTest(issue: 'https://github.com/dart-lang/linter/issues/5048')
   test_catch_underscores() async {
     await assertDiagnostics(r'''
 f() {
@@ -470,12 +471,9 @@ class A {
   }
 
   test_formalParams_underscores() async {
-    await assertDiagnostics(r'''
+    await assertNoDiagnostics(r'''
 f(int _, int __, int ___) {}
-''', [
-      lint(13, 2),
-      lint(21, 3),
-    ]);
+''');
   }
 
   test_formalParams_underscores_preWildcards() async {