[analyzer] Dot shorthands: Add support for call() and getter executions.

Follow up to comment: https://dart-review.googlesource.com/c/sdk/+/422544/comment/36fb49ba_f9f3c908/

Invocations are rewritten to `FunctionExpressionInvocation`s with a `DotShorthandPropertyAccess` as its `function`. Any actual static method invocations are kept as is.

Added some special handling of dot shorthands in the `method_invocation_resolver` to rewrite an invocation to a property access with a function expression invocation as a parent. The static type is set for later usage in the `function_expression_invocation_resolver`.

`language/dot_shorthands/simple/call_test` passing and unit tests added.

Bug: #59835
Change-Id: I42649cefab54f80dc96357a03e208ad374183d09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/423211
Reviewed-by: Paul Berry <[email protected]>
Reviewed-by: Chloe Stefantsova <[email protected]>
Commit-Queue: Kallen Tu <[email protected]>

Author: kallentu

pkg/analyzer/lib/src/dart/resolver/method_invocation_resolver.dart

@@ -1315,7 +1315,16 @@ class MethodInvocationResolver with ScopeHelpers {
 
     ExpressionImpl functionExpression;
     if (target == null) {
-      functionExpression = methodName;
+      if (node is DotShorthandInvocationImpl) {
+        functionExpression = DotShorthandPropertyAccessImpl(
+          period: node.period,
+          propertyName: node.memberName,
+        );
+        functionExpression.setPseudoExpressionStaticType(targetType);
+      } else {
+        functionExpression = methodName;
+      }
+
       var element = methodName.element;
       if (element is ExecutableElement2 &&
           element.enclosingElement2 is InstanceElement2 &&

pkg/analyzer/lib/src/generated/resolver.dart

@@ -2434,7 +2434,8 @@ class ResolverVisitor extends ThrowingAstVisitor<void>
     );
     switch (rewrittenExpression) {
       case null:
-        // TODO(kallentu): Report an error here.
+        // In this case, we didn't rewrite anything. The [node] is a static
+        // method invocation.
         break;
       case FunctionExpressionInvocationImpl():
         _resolveRewrittenFunctionExpressionInvocation(

pkg/analyzer/test/src/dart/resolution/dot_shorthand_invocation_test.dart

@@ -2,6 +2,7 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analyzer/src/error/codes.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import 'context_collection_resolution.dart';
@@ -128,6 +129,99 @@ DotShorthandInvocation
 ''');
   }
 
+  test_call_getter() async {
+    await assertNoErrorsInCode(r'''
+class C {
+  const C();
+  static C get id1 => const C();
+  C call() => const C();
+}
+
+void main() {
+  C c1 = .id1();
+  print(c1);
+}
+''');
+
+    // The [DotShorthandInvocation] is rewritten to a
+    // [FunctionExpressionInvocation].
+    var node = findNode.singleFunctionExpressionInvocation;
+    assertResolvedNodeText(node, r'''
+FunctionExpressionInvocation
+  function: DotShorthandPropertyAccess
+    period: .
+    propertyName: SimpleIdentifier
+      token: id1
+      element: <testLibraryFragment>::@class::C::@getter::id1#element
+      staticType: C
+    staticType: C
+  argumentList: ArgumentList
+    leftParenthesis: (
+    rightParenthesis: )
+  element: <testLibraryFragment>::@class::C::@method::call#element
+  staticInvokeType: C Function()
+  staticType: C
+''');
+  }
+
+  test_call_noCallMethod() async {
+    await assertErrorsInCode(
+      r'''
+class C {
+  const C();
+  static C id1 = const C();
+}
+
+void main() {
+  C c1 = .id1();
+  print(c1);
+}
+''',
+      [
+        error(
+          CompileTimeErrorCode.INVOCATION_OF_NON_FUNCTION_EXPRESSION,
+          77,
+          4,
+        ),
+      ],
+    );
+  }
+
+  test_call_property() async {
+    await assertNoErrorsInCode(r'''
+class C {
+  const C();
+  static C id1 = const C();
+  C call() => const C();
+}
+
+void main() {
+  C c1 = .id1();
+  print(c1);
+}
+''');
+
+    // The [DotShorthandInvocation] is rewritten to a
+    // [FunctionExpressionInvocation].
+    var node = findNode.singleFunctionExpressionInvocation;
+    assertResolvedNodeText(node, r'''
+FunctionExpressionInvocation
+  function: DotShorthandPropertyAccess
+    period: .
+    propertyName: SimpleIdentifier
+      token: id1
+      element: <testLibraryFragment>::@class::C::@getter::id1#element
+      staticType: C
+    staticType: C
+  argumentList: ArgumentList
+    leftParenthesis: (
+    rightParenthesis: )
+  element: <testLibraryFragment>::@class::C::@method::call#element
+  staticInvokeType: C Function()
+  staticType: C
+''');
+  }
+
   test_equality() async {
     await assertNoErrorsInCode('''
 class C {