Skip to content

Commit af1f26f

Browse files
sigmundchcommit-bot@chromium.org
sigmundch
authored and
[email protected]
committed
Status fixes round 5: chrome mac & windows
[email protected] Change-Id: I69db60955cd22aca48981bb84a2637a28c385cc4 Reviewed-on: https://dart-review.googlesource.com/46422 Reviewed-by: Sigmund Cherem <[email protected]> Commit-Queue: Sigmund Cherem <[email protected]>
1 parent 52c884d commit af1f26f

File tree

6 files changed

+38
-32
lines changed

6 files changed

+38
-32
lines changed

‎pkg/pkg.status

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -169,15 +169,15 @@ front_end/test/mixin_export_test: RuntimeError # Issue 30576
169169
[ $compiler == dart2js && $runtime == drt ]
170170
async/test/stream_zip_test: RuntimeError, Pass # Issue 18548
171171

172-
[ $compiler == dart2js && $browser ]
173-
crypto/test/sha1_test: Slow, Pass
174-
crypto/test/sha256_test: Slow, Pass
175-
176-
[ $compiler == dart2js && $browser && $fast_startup && $fasta ]
172+
[ $compiler == dart2js && $system == linux && $browser && $fast_startup && $fasta ]
177173
analysis_server_client/test/analysis_server_client_test: RuntimeError
178174
js_ast/test/printer_callback_test: RuntimeError
179175
js_ast/test/string_escape_test: RuntimeError
180176

177+
[ $compiler == dart2js && $browser ]
178+
crypto/test/sha1_test: Slow, Pass
179+
crypto/test/sha256_test: Slow, Pass
180+
181181
[ $compiler == dart2js && $checked ]
182182
crypto/test/base64_test: Slow, Pass
183183

‎tests/html/html.status

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -397,6 +397,9 @@ xhr_test/xhr: Pass, Fail # Issue 11602
397397
[ $compiler == dart2js && $runtime == ff && $system == windows ]
398398
websql_test: Pass # Triage, seen some double reporting on windows.
399399

400+
[ $compiler == dart2js && $system == linux && !$csp && $fast_startup && $fasta ]
401+
websql_test/Database/Database: RuntimeError
402+
400403
[ $compiler == dart2js && $browser ]
401404
custom/created_callback_test: Fail # Support for created constructor. Issue 14835
402405
fontface_loaded_test: Fail # Support for promises.
@@ -485,9 +488,6 @@ js_util_test: SkipByDesign
485488
mirrors_js_typed_interop_test: SkipByDesign
486489
postmessage_structured_test: SkipByDesign
487490

488-
[ $compiler == dart2js && !$csp && $fast_startup && $fasta ]
489-
websql_test/Database/Database: RuntimeError
490-
491491
[ $compiler == dart2js && $fast_startup ]
492492
custom/mirrors_2_test: Fail # mirrors not supported
493493
custom/mirrors_test: Fail # mirrors not supported

‎tests/isolate/isolate.status

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,11 +86,11 @@ timer_isolate_test: Fail, OK # Needs Timer to run.
8686
cross_isolate_message_test: Skip # Issue 12627
8787
message_test: Skip # Issue 12627
8888

89-
[ $compiler == dart2js && $browser && !$csp && $fast_startup && $fasta ]
89+
[ $compiler == dart2js && $system == linux && $browser && !$csp && $fast_startup && $fasta ]
9090
browser/package_resolve_browser_hook2_test: RuntimeError
9191
browser/package_resolve_browser_test: RuntimeError
9292

93-
[ $compiler == dart2js && $browser && $fast_startup && $fasta ]
93+
[ $compiler == dart2js && $system == linux && $browser && $fast_startup && $fasta ]
9494
browser/package_resolve_browser_hook_test: RuntimeError
9595

9696
[ $compiler == dart2js && !$browser && $fast_startup ]

‎tests/language/language_dart2js.status

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,12 @@ vm/*: Skip # Issue 12699
1616
[ $arch == ia32 && $compiler == dart2js && $runtime == d8 ]
1717
new_expression2_negative_test: Pass, Crash # Flaky, issue 31131
1818

19+
[ $builder_tag == win7 && $compiler == dart2js && $fasta ]
20+
deep_nesting2_negative_test: Crash
21+
illegal_declaration_test/01: Crash
22+
issue1578_negative_test: Crash
23+
regress_23051_test/01: Crash
24+
1925
[ $compiler == dart2js && $runtime == chrome && $system == macos ]
2026
await_future_test: Pass, Timeout # Issue 26735
2127

@@ -63,18 +69,18 @@ regress_23996_test: RuntimeError # Jsshell does not provide non-zero timers, Iss
6369
[ $compiler == dart2js && $runtime == safari ]
6470
round_test: Fail, OK # Common JavaScript engine Math.round bug.
6571

66-
[ $compiler == dart2js && $system == windows && ($runtime == chrome || $runtime == ff) ]
72+
[ $compiler == dart2js && $system == linux && $browser && !$csp && $fast_startup && $fasta ]
73+
async_await_test: RuntimeError
74+
async_star_pause_test: RuntimeError
75+
async_star_test: RuntimeError
76+
77+
[ $compiler == dart2js && $system == windows && !$fasta && ($runtime == chrome || $runtime == ff) ]
6778
string_literals_test: RuntimeError # Issue 27533
6879

6980
[ $compiler == dart2js && $browser && $csp && !$fast_startup ]
7081
conditional_import_string_test: Fail # Issue 30615
7182
conditional_import_test: Fail # Issue 30615
7283

73-
[ $compiler == dart2js && $browser && !$csp && $fast_startup && $fasta ]
74-
async_await_test: RuntimeError
75-
async_star_pause_test: RuntimeError
76-
async_star_test: RuntimeError
77-
7884
[ $compiler == dart2js && $browser && !$fasta ]
7985
config_import_test: Fail # Test flag is not passed to the compiler.
8086
library_env_test/has_io_support: RuntimeError # Issue 27398

‎tests/lib/lib.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ async/zone_create_timer2_test: RuntimeError # Timer interface not supported: Iss
246246
async/zone_empty_description2_test: RuntimeError # Timer interface not supported: Issue 7728.
247247
mirrors/mirrors_reader_test: Skip # Running in v8 suffices. Issue 16589 - RuntimeError. Issue 22130 - Crash (out of memory).
248248

249-
[ $compiler == dart2js && $browser && !$csp && $fast_startup && $fasta ]
249+
[ $compiler == dart2js && $system == linux && $browser && !$csp && $fast_startup && $fasta ]
250250
async/stream_iterator_test: RuntimeError
251251

252252
[ $compiler == dart2js && $checked ]

‎tests/lib_2/lib_2_dart2js.status

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -504,6 +504,21 @@ isolate/message_test: Skip # Issue 12627
504504
[ $compiler == dart2js && $system == linux ]
505505
html/interactive_geolocation_test: Skip # Requires allowing geo location.
506506

507+
[ $compiler == dart2js && $system == linux && $browser && !$csp && $fast_startup && $fasta ]
508+
async/stream_iterator_test: RuntimeError
509+
html/fileapi_directory_reader_test: RuntimeError
510+
html/fileapi_directory_test: RuntimeError
511+
html/fileapi_file_entry_test: RuntimeError
512+
html/fileapi_file_test: RuntimeError
513+
html/fileapi_supported_test: RuntimeError
514+
html/fileapi_supported_throws_test: RuntimeError
515+
html/websql_test: RuntimeError
516+
isolate/browser/package_resolve_browser_hook2_test: RuntimeError
517+
isolate/browser/package_resolve_browser_test: RuntimeError
518+
519+
[ $compiler == dart2js && $system == linux && $browser && $fast_startup && $fasta ]
520+
isolate/browser/package_resolve_browser_hook_test: RuntimeError
521+
507522
[ $compiler == dart2js && $system == windows ]
508523
html/xhr_test: RuntimeError
509524

@@ -520,21 +535,6 @@ js/null_test: RuntimeError # Issue 30652
520535
html/custom/element_upgrade_test: Fail # Issue 17298
521536
html/custom/js_custom_test: Fail # Issue 14643
522537

523-
[ $compiler == dart2js && $browser && !$csp && $fast_startup && $fasta ]
524-
async/stream_iterator_test: RuntimeError
525-
html/fileapi_directory_reader_test: RuntimeError
526-
html/fileapi_directory_test: RuntimeError
527-
html/fileapi_file_entry_test: RuntimeError
528-
html/fileapi_file_test: RuntimeError
529-
html/fileapi_supported_test: RuntimeError
530-
html/fileapi_supported_throws_test: RuntimeError
531-
html/websql_test: RuntimeError
532-
isolate/browser/package_resolve_browser_hook2_test: RuntimeError
533-
isolate/browser/package_resolve_browser_test: RuntimeError
534-
535-
[ $compiler == dart2js && $browser && $fast_startup && $fasta ]
536-
isolate/browser/package_resolve_browser_hook_test: RuntimeError
537-
538538
[ $compiler == dart2js && !$browser && $fast_startup ]
539539
isolate/isolate_current_test: Fail # please triage
540540

0 commit comments

Comments
 (0)