fix dummy setters -- grammar requires an identifier

[email protected]

Review URL: https://codereview.chromium.org/974703003

Author: John Messerly

pkg/dev_compiler/lib/src/codegen/js_codegen.dart

@@ -973,7 +973,7 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
       // TODO(jmesserly): use a dummy setter to indicate writable.
       if (!node.isFinal) {
         methods.add(new JS.Method(
-            new JS.PropertyName(name), js.call('function() {}'),
+            new JS.PropertyName(name), js.call('function(_) {}'),
             isSetter: true));
       }
     }

pkg/dev_compiler/lib/src/js/nodes.dart

@@ -1201,7 +1201,10 @@ class Method extends Property {
 
   Method(Expression name, Fun function,
       {this.isGetter: false, this.isSetter: false, this.isStatic: false})
-      : super(name, function);
+      : super(name, function) {
+    assert(!isGetter || function.params.length == 0);
+    assert(!isSetter || function.params.length == 1);
+  }
 
   Fun get function => super.value;
 

pkg/dev_compiler/test/codegen/expect/_isolate_helper/_isolate_helper.js

@@ -708,7 +708,7 @@ var _isolate_helper;
     get thisScript() {
       return computeThisScript();
     },
-    set thisScript() {},
+    set thisScript(_) {},
     get workerIds() {
       return new core.Expando();
     }

pkg/dev_compiler/test/codegen/expect/_native_typed_data/_native_typed_data.js

@@ -1484,11 +1484,11 @@ var _native_typed_data;
     get _list() {
       return new NativeFloat64List(2);
     },
-    set _list() {},
+    set _list(_) {},
     get _uint32View() {
       return dart.as(_list.buffer.asUint32List(), NativeUint32List);
     },
-    set _uint32View() {}
+    set _uint32View(_) {}
   });
   // Exports:
   exports.NativeByteBuffer = NativeByteBuffer;

pkg/dev_compiler/test/codegen/expect/async/async.js

@@ -3764,7 +3764,7 @@ var async;
       get _SENTINEL() {
         return new core.Object();
       },
-      set _SENTINEL() {}
+      set _SENTINEL(_) {}
     });
     return _DistinctStream;
   });
@@ -4715,7 +4715,7 @@ var async;
     get _rootMap() {
       return new collection.HashMap();
     },
-    set _rootMap() {}
+    set _rootMap(_) {}
   });
   let _ROOT_ZONE = new _RootZone();
   // Function runZoned: (() → dynamic, {zoneValues: Map<dynamic, dynamic>, zoneSpecification: ZoneSpecification, onError: Function}) → dynamic

pkg/dev_compiler/test/codegen/expect/convert/convert.js

@@ -703,7 +703,7 @@ var convert;
     get _nameToEncoding() {
       return dart.map({"iso_8859-1:1987": LATIN1, "iso-ir-100": LATIN1, "iso_8859-1": LATIN1, "iso-8859-1": LATIN1, latin1: LATIN1, l1: LATIN1, ibm819: LATIN1, cp819: LATIN1, csisolatin1: LATIN1, "iso-ir-6": ASCII, "ansi_x3.4-1968": ASCII, "ansi_x3.4-1986": ASCII, "iso_646.irv:1991": ASCII, "iso646-us": ASCII, "us-ascii": ASCII, us: ASCII, ibm367: ASCII, cp367: ASCII, csascii: ASCII, ascii: ASCII, csutf8: UTF8, "utf-8": UTF8});
     },
-    set _nameToEncoding() {}
+    set _nameToEncoding(_) {}
   });
   let HTML_ESCAPE = new HtmlEscape();
   class HtmlEscapeMode extends dart.Object {

pkg/dev_compiler/test/codegen/expect/fieldtest/fieldtest.js

@@ -39,7 +39,7 @@ var fieldtest;
     get y() {
       return compute() + 444;
     },
-    set y() {}
+    set y(_) {}
   });
   dart.copyProperties(exports, {
     get q() {

pkg/dev_compiler/test/codegen/expect/html_input_c/html_input_c.js

@@ -5,6 +5,6 @@ var html_input_c;
     get y() {
       return 3 + html_input_e.w;
     },
-    set y() {}
+    set y(_) {}
   });
 })(html_input_c || (html_input_c = {}));