Skip to content

Commit a2b15f7

Browse files
pqCommit Queue
authored and
Commit Queue
committed
[wildcards] fix super formal parameter handling
Fixes: language/wildcard_variables/initializing_formal_parameters/super_test co19/LanguageFeatures/Wildcards/super_parameters_A04_t01 See: #55680 Change-Id: I7223da0df0f66fcc7b5737af686e34aa387c5c92 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/379721 Commit-Queue: Phil Quitslund <[email protected]> Reviewed-by: Brian Wilkerson <[email protected]>
1 parent ca8afa0 commit a2b15f7

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

pkg/analyzer/lib/src/error/duplicate_definition_verifier.dart

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,14 @@ class DuplicateDefinitionVerifier {
6969
if (identifier != null) {
7070
// The identifier can be null if this is a parameter list for a generic
7171
// function type.
72+
73+
// Skip wildcard `super._`.
74+
if (parameter is SuperFormalParameter &&
75+
identifier.lexeme == '_' &&
76+
_currentLibrary.hasWildcardVariablesFeatureEnabled) {
77+
continue;
78+
}
79+
7280
_checkDuplicateIdentifier(definedNames, identifier,
7381
element: parameter.declaredElement!);
7482
}

pkg/analyzer/test/src/diagnostics/duplicate_definition_test.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2658,8 +2658,6 @@ class B extends A {
26582658
}
26592659
''', [
26602660
error(WarningCode.UNUSED_FIELD, 17, 1),
2661-
error(CompileTimeErrorCode.DUPLICATE_DEFINITION, 74, 1,
2662-
contextMessages: [message(testFile, 65, 1)]),
26632661
]);
26642662
}
26652663

0 commit comments

Comments
 (0)